2022-10-08 08:17:01

by ye xingchen

Subject: [PATCH linux-next] mtd: replace strcmp with sysfs_streq

From: ye xingchen <[email protected]>

Replace the open-code with sysfs_streq().

Signed-off-by: ye xingchen <[email protected]>
---
drivers/mtd/parsers/cmdlinepart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/parsers/cmdlinepart.c
b/drivers/mtd/parsers/cmdlinepart.c
index b34856def816..6a401e0b1b95 100644
--- a/drivers/mtd/parsers/cmdlinepart.c
+++ b/drivers/mtd/parsers/cmdlinepart.c
@@ -154,7 +154,7 @@ static struct mtd_partition * newpart(char *s,
}

/* if slc is found use emulated SLC mode on this partition*/
- if (!strncmp(s, "slc", 3)) {
+ if (sysfs_streq(s, "slc")) {
add_flags |= MTD_SLC_ON_MLC_EMULATION;
s += 3;
}
--
2.25.1

2022-10-15 09:48:27

by Miquel Raynal

Subject: Re: [PATCH linux-next] mtd: replace strcmp with sysfs_streq

Hi [email protected],

[email protected] wrote on Sat, 8 Oct 2022 07:46:43 +0000:

> From: ye xingchen <[email protected]>
>
> Replace the open-code with sysfs_streq().
>
> Signed-off-by: ye xingchen <[email protected]>
> ---
> drivers/mtd/parsers/cmdlinepart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/parsers/cmdlinepart.c
> b/drivers/mtd/parsers/cmdlinepart.c
> index b34856def816..6a401e0b1b95 100644
> --- a/drivers/mtd/parsers/cmdlinepart.c
> +++ b/drivers/mtd/parsers/cmdlinepart.c
> @@ -154,7 +154,7 @@ static struct mtd_partition * newpart(char *s,
> }
>
> /* if slc is found use emulated SLC mode on this partition*/
> - if (!strncmp(s, "slc", 3)) {
> + if (sysfs_streq(s, "slc")) {

I'm sorry but, why this would be a use for sysfs_streq? The point of
this helper is to consider "\n" null, which is not relevant here. Or do
I miss something?

> add_flags |= MTD_SLC_ON_MLC_EMULATION;
> s += 3;
> }


Thanks,
Miquèl