If CONFIG_ACPI is not set,
gcc warns about unused variable:
drivers/i2c/busses/i2c-mlxbf.c:2206:35: error: ‘mlxbf_i2c_chip’ defined but not used [-Werror=unused-variable]
static struct mlxbf_i2c_chip_info mlxbf_i2c_chip[] = {
^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
Mark these variables as __maybe_unused to fix this.
Fixes: b5b5b32081cd ("i2c: mlxbf: I2C SMBus driver for Mellanox BlueField SoC")
Signed-off-by: Ren Zhijie <[email protected]>
---
drivers/i2c/busses/i2c-mlxbf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-mlxbf.c b/drivers/i2c/busses/i2c-mlxbf.c
index e68e775f187e..087df1a53797 100644
--- a/drivers/i2c/busses/i2c-mlxbf.c
+++ b/drivers/i2c/busses/i2c-mlxbf.c
@@ -2203,7 +2203,7 @@ static u32 mlxbf_i2c_functionality(struct i2c_adapter *adap)
return MLXBF_I2C_FUNC_ALL;
}
-static struct mlxbf_i2c_chip_info mlxbf_i2c_chip[] = {
+static struct mlxbf_i2c_chip_info __maybe_unused mlxbf_i2c_chip[] = {
[MLXBF_I2C_CHIP_TYPE_1] = {
.type = MLXBF_I2C_CHIP_TYPE_1,
.shared_res = {
--
2.17.1
Acked-by: Asmaa Mnebhi
-----Original Message-----
From: Ren Zhijie <[email protected]>
Sent: Sunday, October 9, 2022 9:38 AM
To: Khalil Blaiech <[email protected]>; Asmaa Mnebhi <[email protected]>; Vadim Pasternak <[email protected]>; [email protected]
Cc: [email protected]; [email protected]; Ren Zhijie <[email protected]>
Subject: [PATCH -next] i2c: mlxbf: Fix unused-variable warning
If CONFIG_ACPI is not set,
gcc warns about unused variable:
drivers/i2c/busses/i2c-mlxbf.c:2206:35: error: ‘mlxbf_i2c_chip’ defined but not used [-Werror=unused-variable] static struct mlxbf_i2c_chip_info mlxbf_i2c_chip[] = {
^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
Mark these variables as __maybe_unused to fix this.
Fixes: b5b5b32081cd ("i2c: mlxbf: I2C SMBus driver for Mellanox BlueField SoC")
Signed-off-by: Ren Zhijie <[email protected]>
---
drivers/i2c/busses/i2c-mlxbf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-mlxbf.c b/drivers/i2c/busses/i2c-mlxbf.c index e68e775f187e..087df1a53797 100644
--- a/drivers/i2c/busses/i2c-mlxbf.c
+++ b/drivers/i2c/busses/i2c-mlxbf.c
@@ -2203,7 +2203,7 @@ static u32 mlxbf_i2c_functionality(struct i2c_adapter *adap)
return MLXBF_I2C_FUNC_ALL;
}
-static struct mlxbf_i2c_chip_info mlxbf_i2c_chip[] = {
+static struct mlxbf_i2c_chip_info __maybe_unused mlxbf_i2c_chip[] = {
[MLXBF_I2C_CHIP_TYPE_1] = {
.type = MLXBF_I2C_CHIP_TYPE_1,
.shared_res = {
--
2.17.1
On Mon, Oct 10, 2022 at 12:00:09PM +0000, Asmaa Mnebhi wrote:
> Acked-by: Asmaa Mnebhi
You need to add your email address as well.
> If CONFIG_ACPI is not set,
Since DT support is gone now, shouldn't the driver actually depend on
ACPI now? Then, we could get rid of all the #ifdefs in the code?
On Wed, Oct 19, 2022 at 09:44:21PM +0200, [email protected] wrote:
> On Mon, Oct 10, 2022 at 12:00:09PM +0000, Asmaa Mnebhi wrote:
> > Acked-by: Asmaa Mnebhi
>
> You need to add your email address as well.
>
> > If CONFIG_ACPI is not set,
>
> Since DT support is gone now, shouldn't the driver actually depend on
> ACPI now? Then, we could get rid of all the #ifdefs in the code?
This has been submitted and accepted meanwhile:
http://patchwork.ozlabs.org/project/linux-i2c/patch/S229897AbiJTWqk/[email protected]/