2022-10-11 00:37:34

by Samuel Thibault

[permalink] [raw]
Subject: Re: [PATCH] speakup: remove usage of non-standard u_char

Yureka, le mar. 11 oct. 2022 02:17:43 +0200, a ecrit:
> From: Yureka Lilian <[email protected]>
>
> This code is included in the build tools makemapdata and genmap, and it
> expects that libc exposes a definition of u_char. But u_char is not
> defined in either C or POSIX standards, and some systems don't have it.
> Namely this breaks the build on hosts using musl libc, because musl only
> exposes u_char if _GNU_SOURCE is defined.
>
> Signed-off-by: Yureka Lilian <[email protected]>

Reviewed-by: Samuel Thibault <[email protected]>

> ---
>  drivers/accessibility/speakup/utils.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
> index 4bf2ee8ac..4ce9a12f7 100644
> --- a/drivers/accessibility/speakup/utils.h
> +++ b/drivers/accessibility/speakup/utils.h
> @@ -54,7 +54,7 @@ static inline int oops(const char *msg, const char *info)
>  
>  static inline struct st_key *hash_name(char *name)
>  {
> -   u_char *pn = (u_char *)name;
> +   unsigned char *pn = (unsigned char *)name;
>     int hash = 0;
>  
>     while (*pn) {
> --
> 2.37.3