2022-10-20 12:06:45

by Ulf Hansson

Subject: [PATCH] cpuidle: psci: Extend information in log about OSI/PC mode

It's useful to understand whether we are using OS-initiated (OSI) mode or
Platform Coordinated (PC) mode, when initializing the CPU PM domains.
Therefore, let's extend the print in the log after a successful probe with
this information.

Signed-off-by: Ulf Hansson <[email protected]>
---
drivers/cpuidle/cpuidle-psci-domain.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c
index 821984947ed9..c80cf9ddabd8 100644
--- a/drivers/cpuidle/cpuidle-psci-domain.c
+++ b/drivers/cpuidle/cpuidle-psci-domain.c
@@ -181,7 +181,8 @@ static int psci_cpuidle_domain_probe(struct platform_device *pdev)
if (ret)
goto remove_pd;

- pr_info("Initialized CPU PM domain topology\n");
+ pr_info("Initialized CPU PM domain topology using %s mode\n",
+ use_osi ? "OSI" : "PC");
return 0;

put_node:
--
2.34.1

2022-10-25 11:25:09

by Sudeep Holla

Subject: Re: [PATCH] cpuidle: psci: Extend information in log about OSI/PC mode

On Thu, Oct 20, 2022 at 01:55:13PM +0200, Ulf Hansson wrote:
> It's useful to understand whether we are using OS-initiated (OSI) mode or
> Platform Coordinated (PC) mode, when initializing the CPU PM domains.
> Therefore, let's extend the print in the log after a successful probe with
> this information.
>

Looks good to me.

Acked-by: Sudeep Holla <[email protected]

--
Regards,
Sudeep

2022-10-25 11:45:03

by Dmitry Baryshkov

Subject: Re: [PATCH] cpuidle: psci: Extend information in log about OSI/PC mode

On 20/10/2022 14:55, Ulf Hansson wrote:
> It's useful to understand whether we are using OS-initiated (OSI) mode or
> Platform Coordinated (PC) mode, when initializing the CPU PM domains.
> Therefore, let's extend the print in the log after a successful probe with
> this information.
>
> Signed-off-by: Ulf Hansson <[email protected]>
> ---
> drivers/cpuidle/cpuidle-psci-domain.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

Acked-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry

2022-10-25 13:56:08

by Rafael J. Wysocki

Subject: Re: [PATCH] cpuidle: psci: Extend information in log about OSI/PC mode

On Thu, Oct 20, 2022 at 1:55 PM Ulf Hansson <[email protected]> wrote:
>
> It's useful to understand whether we are using OS-initiated (OSI) mode or
> Platform Coordinated (PC) mode, when initializing the CPU PM domains.
> Therefore, let's extend the print in the log after a successful probe with
> this information.
>
> Signed-off-by: Ulf Hansson <[email protected]>
> ---
> drivers/cpuidle/cpuidle-psci-domain.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c
> index 821984947ed9..c80cf9ddabd8 100644
> --- a/drivers/cpuidle/cpuidle-psci-domain.c
> +++ b/drivers/cpuidle/cpuidle-psci-domain.c
> @@ -181,7 +181,8 @@ static int psci_cpuidle_domain_probe(struct platform_device *pdev)
> if (ret)
> goto remove_pd;
>
> - pr_info("Initialized CPU PM domain topology\n");
> + pr_info("Initialized CPU PM domain topology using %s mode\n",
> + use_osi ? "OSI" : "PC");
> return 0;
>
> put_node:
> --

Am I expected to pick up this one?

2022-10-25 13:59:20

by Ulf Hansson

Subject: Re: [PATCH] cpuidle: psci: Extend information in log about OSI/PC mode

On Tue, 25 Oct 2022 at 15:16, Rafael J. Wysocki <[email protected]> wrote:
>
> On Thu, Oct 20, 2022 at 1:55 PM Ulf Hansson <[email protected]> wrote:
> >
> > It's useful to understand whether we are using OS-initiated (OSI) mode or
> > Platform Coordinated (PC) mode, when initializing the CPU PM domains.
> > Therefore, let's extend the print in the log after a successful probe with
> > this information.
> >
> > Signed-off-by: Ulf Hansson <[email protected]>
> > ---
> > drivers/cpuidle/cpuidle-psci-domain.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c
> > index 821984947ed9..c80cf9ddabd8 100644
> > --- a/drivers/cpuidle/cpuidle-psci-domain.c
> > +++ b/drivers/cpuidle/cpuidle-psci-domain.c
> > @@ -181,7 +181,8 @@ static int psci_cpuidle_domain_probe(struct platform_device *pdev)
> > if (ret)
> > goto remove_pd;
> >
> > - pr_info("Initialized CPU PM domain topology\n");
> > + pr_info("Initialized CPU PM domain topology using %s mode\n",
> > + use_osi ? "OSI" : "PC");
> > return 0;
> >
> > put_node:
> > --
>
> Am I expected to pick up this one?

Yes, please!

Kind regards
Uffe

2022-10-28 19:02:40

by Rafael J. Wysocki

Subject: Re: [PATCH] cpuidle: psci: Extend information in log about OSI/PC mode

On Tue, Oct 25, 2022 at 3:18 PM Ulf Hansson <[email protected]> wrote:
>
> On Tue, 25 Oct 2022 at 15:16, Rafael J. Wysocki <[email protected]> wrote:
> >
> > On Thu, Oct 20, 2022 at 1:55 PM Ulf Hansson <[email protected]> wrote:
> > >
> > > It's useful to understand whether we are using OS-initiated (OSI) mode or
> > > Platform Coordinated (PC) mode, when initializing the CPU PM domains.
> > > Therefore, let's extend the print in the log after a successful probe with
> > > this information.
> > >
> > > Signed-off-by: Ulf Hansson <[email protected]>
> > > ---
> > > drivers/cpuidle/cpuidle-psci-domain.c | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c
> > > index 821984947ed9..c80cf9ddabd8 100644
> > > --- a/drivers/cpuidle/cpuidle-psci-domain.c
> > > +++ b/drivers/cpuidle/cpuidle-psci-domain.c
> > > @@ -181,7 +181,8 @@ static int psci_cpuidle_domain_probe(struct platform_device *pdev)
> > > if (ret)
> > > goto remove_pd;
> > >
> > > - pr_info("Initialized CPU PM domain topology\n");
> > > + pr_info("Initialized CPU PM domain topology using %s mode\n",
> > > + use_osi ? "OSI" : "PC");
> > > return 0;
> > >
> > > put_node:
> > > --
> >
> > Am I expected to pick up this one?
>
> Yes, please!

Done, thanks!