On Thu, Oct 20, 2022 at 02:45:22PM +0100, Colin King (gmail) wrote:
> I noticed a signed / unsigned comparison warning when building linux-next
> with clang. I believe it was introduced in the following commit:
>
> commit dab902fe1d29dc0fa1dccc8d13dc89ffbf633881
> Author: Tomislav Požega <[email protected]>
> Date: Sat Sep 17 21:28:43 2022 +0100
>
> wifi: rt2x00: add TX LOFT calibration for MT7620
>
>
> The warning is as follows:
>
> drivers/net/wireless/ralink/rt2x00/rt2800lib.c:9472:15: warning: result of
> comparison of constant -7 with expression of type 'char' is always false
> [-Wtautological-constant-out-of-range-compare]
> gerr = (gerr < -0x07) ? -0x07 : (gerr > 0x05) ? 0x05 : gerr;
This was very currently addressed:
https://lore.kernel.org/linux-wireless/[email protected]/
Regards
Stanislaw