2022-10-21 12:26:33

by Miguel Ojeda

Subject: [PATCH 2/5] compiler-gcc: remove attribute support check for `__no_sanitize_address__`

The attribute was added in GCC 4.8, while the minimum GCC version
supported by the kernel is GCC 5.1.

Therefore, remove the check.

Link: https://godbolt.org/z/84v56vcn8
Signed-off-by: Miguel Ojeda <[email protected]>
---
include/linux/compiler-gcc.h | 4 ----
1 file changed, 4 deletions(-)

diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
index b9530d3515ac..bfce7f4d0978 100644
--- a/include/linux/compiler-gcc.h
+++ b/include/linux/compiler-gcc.h
@@ -82,11 +82,7 @@
#define __noscs __attribute__((__no_sanitize__("shadow-call-stack")))
#endif

-#if __has_attribute(__no_sanitize_address__)
#define __no_sanitize_address __attribute__((__no_sanitize_address__))
-#else
-#define __no_sanitize_address
-#endif

#if defined(__SANITIZE_THREAD__) && __has_attribute(__no_sanitize_thread__)
#define __no_sanitize_thread __attribute__((__no_sanitize_thread__))
--
2.38.1

2022-10-21 16:16:33

by Kees Cook

Subject: Re: [PATCH 2/5] compiler-gcc: remove attribute support check for `__no_sanitize_address__`

On Fri, Oct 21, 2022 at 01:59:53PM +0200, Miguel Ojeda wrote:
> The attribute was added in GCC 4.8, while the minimum GCC version
> supported by the kernel is GCC 5.1.
>
> Therefore, remove the check.
>
> Link: https://godbolt.org/z/84v56vcn8
> Signed-off-by: Miguel Ojeda <[email protected]>

Reviewed-by: Kees Cook <[email protected]>

--
Kees Cook

2022-10-21 21:42:51

by Nathan Chancellor

Subject: Re: [PATCH 2/5] compiler-gcc: remove attribute support check for `__no_sanitize_address__`

On Fri, Oct 21, 2022 at 01:59:53PM +0200, Miguel Ojeda wrote:
> The attribute was added in GCC 4.8, while the minimum GCC version
> supported by the kernel is GCC 5.1.
>
> Therefore, remove the check.
>
> Link: https://godbolt.org/z/84v56vcn8
> Signed-off-by: Miguel Ojeda <[email protected]>

Reviewed-by: Nathan Chancellor <[email protected]>

> ---
> include/linux/compiler-gcc.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
> index b9530d3515ac..bfce7f4d0978 100644
> --- a/include/linux/compiler-gcc.h
> +++ b/include/linux/compiler-gcc.h
> @@ -82,11 +82,7 @@
> #define __noscs __attribute__((__no_sanitize__("shadow-call-stack")))
> #endif
>
> -#if __has_attribute(__no_sanitize_address__)
> #define __no_sanitize_address __attribute__((__no_sanitize_address__))
> -#else
> -#define __no_sanitize_address
> -#endif
>
> #if defined(__SANITIZE_THREAD__) && __has_attribute(__no_sanitize_thread__)
> #define __no_sanitize_thread __attribute__((__no_sanitize_thread__))
> --
> 2.38.1
>
>