2022-10-25 06:44:27

by Yang Li

Subject: [PATCH -next] drm/amdkfd: clean up some inconsistent indentings

drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_migrate.c:331 svm_migrate_copy_to_vram() warn: inconsistent indenting

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2537
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
index 20d6b2578927..cddf259875c0 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
@@ -328,8 +328,7 @@ svm_migrate_copy_to_vram(struct amdgpu_device *adev, struct svm_range *prange,

dst[i] = cursor.start + (j << PAGE_SHIFT);
migrate->dst[i] = svm_migrate_addr_to_pfn(adev, dst[i]);
- svm_migrate_get_vram_page(&kfddev->pgmap, prange,
- migrate->dst[i]);
+ svm_migrate_get_vram_page(&kfddev->pgmap, prange, migrate->dst[i]);
migrate->dst[i] = migrate_pfn(migrate->dst[i]);

spage = migrate_pfn_to_page(migrate->src[i]);
--
2.20.1.7.g153144c

2022-10-25 20:33:03

by Felix Kuehling

Subject: Re: [PATCH -next] drm/amdkfd: clean up some inconsistent indentings

Am 2022-10-25 um 02:09 schrieb Yang Li:
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_migrate.c:331 svm_migrate_copy_to_vram() warn: inconsistent indenting
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2537
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>

This patch doesn't apply to our amd-staging-drm-next, nor to the
kernel.org master branch. Which branch is this against?

Thanks,
  Felix


> ---
> drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
> index 20d6b2578927..cddf259875c0 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
> @@ -328,8 +328,7 @@ svm_migrate_copy_to_vram(struct amdgpu_device *adev, struct svm_range *prange,
>
> dst[i] = cursor.start + (j << PAGE_SHIFT);
> migrate->dst[i] = svm_migrate_addr_to_pfn(adev, dst[i]);
> - svm_migrate_get_vram_page(&kfddev->pgmap, prange,
> - migrate->dst[i]);
> + svm_migrate_get_vram_page(&kfddev->pgmap, prange, migrate->dst[i]);
> migrate->dst[i] = migrate_pfn(migrate->dst[i]);
>
> spage = migrate_pfn_to_page(migrate->src[i]);