2022-11-03 18:26:34

by Julien Panis

Subject: [PATCH v2 0/2] AM62x watchdog support

This patch series adds support for AM62x watchdog.

Changes since v0:
- Mark MCU & WKUP watchdogs as reserved
Link: https://lore.kernel.org/all/[email protected]/

Changes since v1:
- Rebase patch to v6.1-rc3
Link: https://lore.kernel.org/all/[email protected]/

Julien Panis (2):
arm64: dts: ti: k3-am62: add watchdog nodes
arm64: dts: ti: k3-am625-sk: mark MCU and WKUP watchdogs as reserved

arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 45 ++++++++++++++++++++++
arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi | 9 +++++
arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi | 9 +++++
arch/arm64/boot/dts/ti/k3-am625-sk.dts | 10 +++++
4 files changed, 73 insertions(+)


base-commit: 30a0b95b1335e12efef89dd78518ed3e4a71a763
--
2.37.3

2022-11-03 18:29:10

by Julien Panis

Subject: [PATCH v2 2/2] arm64: dts: ti: k3-am625-sk: mark MCU and WKUP watchdogs as reserved

MCU wdt is typically used by M4F.
Wake up wdt is typically used by DM (R5) firmware.

Signed-off-by: Julien Panis <[email protected]>
---
arch/arm64/boot/dts/ti/k3-am625-sk.dts | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am625-sk.dts b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
index 93a5f0817efc..9ade591ef563 100644
--- a/arch/arm64/boot/dts/ti/k3-am625-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
@@ -503,6 +503,16 @@ &main_mcan0 {
status = "disabled";
};

+&mcu_rti0 {
+ /* MCU RTI0 is used by M4F firmware */
+ status = "reserved";
+};
+
+&wkup_rti0 {
+ /* WKUP RTI0 is used by DM firmware */
+ status = "reserved";
+};
+
&epwm0 {
status = "disabled";
};
--
2.37.3

2022-11-03 23:06:16

by Nishanth Menon

Subject: Re: [PATCH v2 2/2] arm64: dts: ti: k3-am625-sk: mark MCU and WKUP watchdogs as reserved

On 19:14-20221103, Julien Panis wrote:
> MCU wdt is typically used by M4F.
> Wake up wdt is typically used by DM (R5) firmware.
>
> Signed-off-by: Julien Panis <[email protected]>
> ---
> arch/arm64/boot/dts/ti/k3-am625-sk.dts | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am625-sk.dts b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
> index 93a5f0817efc..9ade591ef563 100644
> --- a/arch/arm64/boot/dts/ti/k3-am625-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
> @@ -503,6 +503,16 @@ &main_mcan0 {
> status = "disabled";
> };
>
> +&mcu_rti0 {
> + /* MCU RTI0 is used by M4F firmware */
> + status = "reserved";
> +};
> +
> +&wkup_rti0 {
> + /* WKUP RTI0 is used by DM firmware */
> + status = "reserved";
> +};
> +

If this is the typical usage, should'nt we do this in soc.dtsi than
sprinkle this through various boards?

Andrew: ?
> &epwm0 {
> status = "disabled";
> };
> --
> 2.37.3
>

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

2022-11-03 23:08:04

by Andrew Davis

Subject: Re: [PATCH v2 2/2] arm64: dts: ti: k3-am625-sk: mark MCU and WKUP watchdogs as reserved

On 11/3/22 4:47 PM, Nishanth Menon wrote:
> On 19:14-20221103, Julien Panis wrote:
>> MCU wdt is typically used by M4F.
>> Wake up wdt is typically used by DM (R5) firmware.
>>
>> Signed-off-by: Julien Panis <[email protected]>
>> ---
>> arch/arm64/boot/dts/ti/k3-am625-sk.dts | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am625-sk.dts b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
>> index 93a5f0817efc..9ade591ef563 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am625-sk.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
>> @@ -503,6 +503,16 @@ &main_mcan0 {
>> status = "disabled";
>> };
>>
>> +&mcu_rti0 {
>> + /* MCU RTI0 is used by M4F firmware */
>> + status = "reserved";
>> +};
>> +
>> +&wkup_rti0 {
>> + /* WKUP RTI0 is used by DM firmware */
>> + status = "reserved";
>> +};
>> +
>
> If this is the typical usage, should'nt we do this in soc.dtsi than
> sprinkle this through various boards?
>
> Andrew: ?

These are only "reserved" for certain firmware, you choose your RPROCs
and firmware down at the bottom level in board DTs. So I'd say these
statuses should be set at this same level here.

DM firmware might be the exception as it should always be present,
but for M4F firmware, meh, leave it here.

Andrew

>> &epwm0 {
>> status = "disabled";
>> };
>> --
>> 2.37.3
>>
>

2022-11-03 23:34:27

by Nishanth Menon

Subject: Re: [PATCH v2 2/2] arm64: dts: ti: k3-am625-sk: mark MCU and WKUP watchdogs as reserved

On 17:36-20221103, Andrew Davis wrote:
> On 11/3/22 4:47 PM, Nishanth Menon wrote:
> > On 19:14-20221103, Julien Panis wrote:
> > > MCU wdt is typically used by M4F.
> > > Wake up wdt is typically used by DM (R5) firmware.
> > >
> > > Signed-off-by: Julien Panis <[email protected]>
> > > ---
> > > arch/arm64/boot/dts/ti/k3-am625-sk.dts | 10 ++++++++++
> > > 1 file changed, 10 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/ti/k3-am625-sk.dts b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
> > > index 93a5f0817efc..9ade591ef563 100644
> > > --- a/arch/arm64/boot/dts/ti/k3-am625-sk.dts
> > > +++ b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
> > > @@ -503,6 +503,16 @@ &main_mcan0 {
> > > status = "disabled";
> > > };
> > > +&mcu_rti0 {
> > > + /* MCU RTI0 is used by M4F firmware */
> > > + status = "reserved";
> > > +};
> > > +
> > > +&wkup_rti0 {
> > > + /* WKUP RTI0 is used by DM firmware */
> > > + status = "reserved";
> > > +};
> > > +
> >
> > If this is the typical usage, should'nt we do this in soc.dtsi than
> > sprinkle this through various boards?
> >
> > Andrew: ?
>
> These are only "reserved" for certain firmware, you choose your RPROCs
> and firmware down at the bottom level in board DTs. So I'd say these
> statuses should be set at this same level here.
>
> DM firmware might be the exception as it should always be present,
> but for M4F firmware, meh, leave it here.
>

That makes sense.. Julien: Could you address this please?

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D