2022-11-03 16:01:32

by Keith Busch

Subject: [PATCHv2] iomap: directly use logical block size

From: Keith Busch <[email protected]>

Don't transform the logical block size to a bit shift only to shift it
back to the original block size. Just use the size.

Cc: Christoph Hellwig <[email protected]>
Reviewed-by: Chaitanya Kulkarni <[email protected]>
Reviewed-by: Darrick J. Wong <[email protected]>
Reviewed-by: Bart Van Assche <[email protected]>
Signed-off-by: Keith Busch <[email protected]>
---
v1->v2:

Get rid of the temporary variable since it's only used once (hch)

fs/iomap/direct-io.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
index 4eb559a16c9e..9804714b1751 100644
--- a/fs/iomap/direct-io.c
+++ b/fs/iomap/direct-io.c
@@ -240,7 +240,6 @@ static loff_t iomap_dio_bio_iter(const struct iomap_iter *iter,
{
const struct iomap *iomap = &iter->iomap;
struct inode *inode = iter->inode;
- unsigned int blkbits = blksize_bits(bdev_logical_block_size(iomap->bdev));
unsigned int fs_block_size = i_blocksize(inode), pad;
loff_t length = iomap_length(iter);
loff_t pos = iter->pos;
@@ -252,7 +251,7 @@ static loff_t iomap_dio_bio_iter(const struct iomap_iter *iter,
size_t copied = 0;
size_t orig_count;

- if ((pos | length) & ((1 << blkbits) - 1) ||
+ if ((pos | length) & (bdev_logical_block_size(iomap->bdev) - 1) ||
!bdev_iter_is_aligned(iomap->bdev, dio->submit.iter))
return -EINVAL;

--
2.30.2

2022-11-03 16:46:30

by Matthew Wilcox

Subject: Re: [PATCHv2] iomap: directly use logical block size

On Thu, Nov 03, 2022 at 08:43:39AM -0700, Keith Busch wrote:
> From: Keith Busch <[email protected]>
>
> Don't transform the logical block size to a bit shift only to shift it
> back to the original block size. Just use the size.
>
> Cc: Christoph Hellwig <[email protected]>
> Reviewed-by: Chaitanya Kulkarni <[email protected]>
> Reviewed-by: Darrick J. Wong <[email protected]>
> Reviewed-by: Bart Van Assche <[email protected]>
> Signed-off-by: Keith Busch <[email protected]>

Reviewed-by: Matthew Wilcox (Oracle) <[email protected]>

2022-11-04 05:42:36

by Christoph Hellwig

Subject: Re: [PATCHv2] iomap: directly use logical block size

Looks good:

Reviewed-by: Christoph Hellwig <[email protected]>