2022-11-04 13:24:07

by Steen Hegelund

Subject: [PATCH net-next] net: flow_offload: add support for ARP frame matching

This adds a new flow_rule_match_arp function that allows drivers
to be able to dissect APR frames.

Signed-off-by: Steen Hegelund <[email protected]>
---
include/net/flow_offload.h | 6 ++++++
net/core/flow_offload.c | 7 +++++++
2 files changed, 13 insertions(+)

diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
index 7a60bc6d72c9..0400a0ac8a29 100644
--- a/include/net/flow_offload.h
+++ b/include/net/flow_offload.h
@@ -32,6 +32,10 @@ struct flow_match_vlan {
struct flow_dissector_key_vlan *key, *mask;
};

+struct flow_match_arp {
+ struct flow_dissector_key_arp *key, *mask;
+};
+
struct flow_match_ipv4_addrs {
struct flow_dissector_key_ipv4_addrs *key, *mask;
};
@@ -98,6 +102,8 @@ void flow_rule_match_vlan(const struct flow_rule *rule,
struct flow_match_vlan *out);
void flow_rule_match_cvlan(const struct flow_rule *rule,
struct flow_match_vlan *out);
+void flow_rule_match_arp(const struct flow_rule *rule,
+ struct flow_match_arp *out);
void flow_rule_match_ipv4_addrs(const struct flow_rule *rule,
struct flow_match_ipv4_addrs *out);
void flow_rule_match_ipv6_addrs(const struct flow_rule *rule,
diff --git a/net/core/flow_offload.c b/net/core/flow_offload.c
index abe423fd5736..acfc1f88ea79 100644
--- a/net/core/flow_offload.c
+++ b/net/core/flow_offload.c
@@ -97,6 +97,13 @@ void flow_rule_match_cvlan(const struct flow_rule *rule,
}
EXPORT_SYMBOL(flow_rule_match_cvlan);

+void flow_rule_match_arp(const struct flow_rule *rule,
+ struct flow_match_arp *out)
+{
+ FLOW_DISSECTOR_MATCH(rule, FLOW_DISSECTOR_KEY_ARP, out);
+}
+EXPORT_SYMBOL(flow_rule_match_arp);
+
void flow_rule_match_ipv4_addrs(const struct flow_rule *rule,
struct flow_match_ipv4_addrs *out)
{
--
2.38.1

2022-11-04 13:36:00

by Wojciech Drewek

Subject: RE: [PATCH net-next] net: flow_offload: add support for ARP frame matching

> -----Original Message-----
> From: Steen Hegelund <[email protected]>
> Sent: pi?tek, 4 listopada 2022 13:33
> To: David S . Miller <[email protected]>; Eric Dumazet <[email protected]>; Jakub Kicinski <[email protected]>; Paolo
> Abeni <[email protected]>
> Cc: Steen Hegelund <[email protected]>; Louis Peens <[email protected]>; Baowen Zheng
> <[email protected]>; Simon Horman <[email protected]>; Nguyen, Anthony L
> <[email protected]>; Drewek, Wojciech <[email protected]>; Maksym Glubokiy
> <[email protected]>; Pablo Neira Ayuso <[email protected]>; [email protected]; [email protected];
> [email protected]; Horatiu Vultur <[email protected]>
> Subject: [PATCH net-next] net: flow_offload: add support for ARP frame matching
>
> This adds a new flow_rule_match_arp function that allows drivers
> to be able to dissect APR frames.

ARP* frames
Other than that looks ok.
Reviewed-by: Wojciech Drewek <[email protected]>

>
> Signed-off-by: Steen Hegelund <[email protected]>
> ---
> include/net/flow_offload.h | 6 ++++++
> net/core/flow_offload.c | 7 +++++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
> index 7a60bc6d72c9..0400a0ac8a29 100644
> --- a/include/net/flow_offload.h
> +++ b/include/net/flow_offload.h
> @@ -32,6 +32,10 @@ struct flow_match_vlan {
> struct flow_dissector_key_vlan *key, *mask;
> };
>
> +struct flow_match_arp {
> + struct flow_dissector_key_arp *key, *mask;
> +};
> +
> struct flow_match_ipv4_addrs {
> struct flow_dissector_key_ipv4_addrs *key, *mask;
> };
> @@ -98,6 +102,8 @@ void flow_rule_match_vlan(const struct flow_rule *rule,
> struct flow_match_vlan *out);
> void flow_rule_match_cvlan(const struct flow_rule *rule,
> struct flow_match_vlan *out);
> +void flow_rule_match_arp(const struct flow_rule *rule,
> + struct flow_match_arp *out);
> void flow_rule_match_ipv4_addrs(const struct flow_rule *rule,
> struct flow_match_ipv4_addrs *out);
> void flow_rule_match_ipv6_addrs(const struct flow_rule *rule,
> diff --git a/net/core/flow_offload.c b/net/core/flow_offload.c
> index abe423fd5736..acfc1f88ea79 100644
> --- a/net/core/flow_offload.c
> +++ b/net/core/flow_offload.c
> @@ -97,6 +97,13 @@ void flow_rule_match_cvlan(const struct flow_rule *rule,
> }
> EXPORT_SYMBOL(flow_rule_match_cvlan);
>
> +void flow_rule_match_arp(const struct flow_rule *rule,
> + struct flow_match_arp *out)
> +{
> + FLOW_DISSECTOR_MATCH(rule, FLOW_DISSECTOR_KEY_ARP, out);
> +}
> +EXPORT_SYMBOL(flow_rule_match_arp);
> +
> void flow_rule_match_ipv4_addrs(const struct flow_rule *rule,
> struct flow_match_ipv4_addrs *out)
> {
> --
> 2.38.1

2022-11-07 07:16:01

by Leon Romanovsky

Subject: Re: [PATCH net-next] net: flow_offload: add support for ARP frame matching

On Fri, Nov 04, 2022 at 01:33:14PM +0100, Steen Hegelund wrote:
> This adds a new flow_rule_match_arp function that allows drivers
> to be able to dissect APR frames.
>
> Signed-off-by: Steen Hegelund <[email protected]>
> ---
> include/net/flow_offload.h | 6 ++++++
> net/core/flow_offload.c | 7 +++++++
> 2 files changed, 13 insertions(+)

I don't see any usage of this new API.
Please send this as part of the code that actually uses it.

Thanks