2022-11-11 04:31:52

by Bard Liao

Subject: [PATCH 1/8] soundwire: intel_init: remove useless interrupt enablement in interrupt thread

From: Pierre-Louis Bossart <[email protected]>

When the code reaches the SoundWire interrupt thread handling, the
interrupt was enabled already, and there is no code that disables it
-> this is a no-op sequence.

Signed-off-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Péter Ujfalusi <[email protected]>
Reviewed-by: Ranjani Sridharan <[email protected]>
Signed-off-by: Bard Liao <[email protected]>
---
drivers/soundwire/intel_init.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/soundwire/intel_init.c b/drivers/soundwire/intel_init.c
index d091513919df..8bd95c9cbcaf 100644
--- a/drivers/soundwire/intel_init.c
+++ b/drivers/soundwire/intel_init.c
@@ -157,7 +157,6 @@ irqreturn_t sdw_intel_thread(int irq, void *dev_id)
list_for_each_entry(link, &ctx->link_list, list)
sdw_cdns_irq(irq, link->cdns);

- sdw_intel_enable_irq(ctx->mmio_base, true);
return IRQ_HANDLED;
}
EXPORT_SYMBOL_NS(sdw_intel_thread, SOUNDWIRE_INTEL_INIT);
--
2.25.1

2022-11-23 15:07:37

by Vinod Koul

Subject: Re: [PATCH 1/8] soundwire: intel_init: remove useless interrupt enablement in interrupt thread

On 11-11-22, 12:26, Bard Liao wrote:
> From: Pierre-Louis Bossart <[email protected]>
>
> When the code reaches the SoundWire interrupt thread handling, the
> interrupt was enabled already, and there is no code that disables it
> -> this is a no-op sequence.

Acked-By: Vinod Koul <[email protected]>

--
~Vinod