From: ChanWoo Lee <[email protected]>
For early return, bitmap_len operation is not required.
Modified to reduce unnecessary operations.
Signed-off-by: ChanWoo Lee <[email protected]>
---
drivers/ufs/core/ufshpb.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/ufs/core/ufshpb.c b/drivers/ufs/core/ufshpb.c
index 148017b2dfeb..994f4ac9df5a 100644
--- a/drivers/ufs/core/ufshpb.c
+++ b/drivers/ufs/core/ufshpb.c
@@ -233,11 +233,6 @@ static bool ufshpb_test_ppn_dirty(struct ufshpb_lu *hpb, int rgn_idx,
rgn = hpb->rgn_tbl + rgn_idx;
srgn = rgn->srgn_tbl + srgn_idx;
- if (likely(!srgn->is_last))
- bitmap_len = hpb->entries_per_srgn;
- else
- bitmap_len = hpb->last_srgn_entries;
-
if (!ufshpb_is_valid_srgn(rgn, srgn))
return true;
@@ -253,6 +248,11 @@ static bool ufshpb_test_ppn_dirty(struct ufshpb_lu *hpb, int rgn_idx,
return true;
}
+ if (likely(!srgn->is_last))
+ bitmap_len = hpb->entries_per_srgn;
+ else
+ bitmap_len = hpb->last_srgn_entries;
+
if ((srgn_offset + cnt) > bitmap_len)
bit_len = bitmap_len - srgn_offset;
else
--
2.29.0
Chanwoo,
> For early return, bitmap_len operation is not required. Modified to
> reduce unnecessary operations.
Applied to 6.2/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
On Fri, 11 Nov 2022 15:23:01 +0900, Chanwoo Lee wrote:
> From: ChanWoo Lee <[email protected]>
>
> For early return, bitmap_len operation is not required.
> Modified to reduce unnecessary operations.
>
>
Applied to 6.2/scsi-queue, thanks!
[1/1] scsi: ufs: core: Fix unnecessary operation for early return
https://git.kernel.org/mkp/scsi/c/222d227f375b
--
Martin K. Petersen Oracle Linux Engineering