2022-11-14 12:46:50

by Wayne Chang

Subject: [PATCH v3 08/13] usb: typec: ucsi_ccg: Remove ccgx,firmware-build property

Remove the property ccgx,firmware-build as we have added well-known
regex cypress,firmware-build.

Signed-off-by: Wayne Chang <[email protected]>
---
V2 -> V3:nothing has changed
V1 -> V2:nothing has changed
drivers/usb/typec/ucsi/ucsi_ccg.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c
index e412a457bbfc..eab3012e1b01 100644
--- a/drivers/usb/typec/ucsi/ucsi_ccg.c
+++ b/drivers/usb/typec/ucsi/ucsi_ccg.c
@@ -1359,11 +1359,6 @@ static int ucsi_ccg_probe(struct i2c_client *client,
INIT_WORK(&uc->pm_work, ccg_pm_workaround_work);

/* Only fail FW flashing when FW build information is not provided */
- status = device_property_read_u16(dev, "ccgx,firmware-build",
- &uc->fw_build);
- if (status)
- dev_err(uc->dev, "failed to get FW build information\n");
-
status = device_property_read_string(dev, "cypress,firmware-build",
&of_fw_build);
if (!status) {
--
2.25.1

2022-11-15 12:47:11

by Jon Hunter

Subject: Re: [PATCH v3 08/13] usb: typec: ucsi_ccg: Remove ccgx,firmware-build property

On 14/11/2022 12:40, Wayne Chang wrote:
> Remove the property ccgx,firmware-build as we have added well-known
> regex cypress,firmware-build.
>
> Signed-off-by: Wayne Chang <[email protected]>
> ---
> V2 -> V3:nothing has changed
> V1 -> V2:nothing has changed
> drivers/usb/typec/ucsi/ucsi_ccg.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c
> index e412a457bbfc..eab3012e1b01 100644
> --- a/drivers/usb/typec/ucsi/ucsi_ccg.c
> +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c
> @@ -1359,11 +1359,6 @@ static int ucsi_ccg_probe(struct i2c_client *client,
> INIT_WORK(&uc->pm_work, ccg_pm_workaround_work);
>
> /* Only fail FW flashing when FW build information is not provided */
> - status = device_property_read_u16(dev, "ccgx,firmware-build",
> - &uc->fw_build);
> - if (status)
> - dev_err(uc->dev, "failed to get FW build information\n");
> -
> status = device_property_read_string(dev, "cypress,firmware-build",
> &of_fw_build);
> if (!status) {

Reviewed-by: Jon Hunter <[email protected]>

Thanks
Jon

--
nvpublic