2022-11-21 11:05:47

by Yang Li

Subject: [PATCH -next] mm/hugetlb: stop using 0 as NULL pointer

mm/hugetlb.c:1531:37: warning: Using plain integer as NULL pointer

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3224
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
mm/hugetlb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 222937d512c4..b6c2fc882f21 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -1528,7 +1528,7 @@ static void add_hugetlb_folio(struct hstate *h, struct folio *folio,
}

folio_set_compound_dtor(folio, HUGETLB_PAGE_DTOR);
- folio_change_private(folio, 0);
+ folio_change_private(folio, NULL);
/*
* We have to set HPageVmemmapOptimized again as above
* folio_change_private(folio, 0) cleared it.
--
2.20.1.7.g153144c

2022-11-21 13:07:21

by David Hildenbrand

Subject: Re: [PATCH -next] mm/hugetlb: stop using 0 as NULL pointer

On 21.11.22 11:20, Yang Li wrote:
> mm/hugetlb.c:1531:37: warning: Using plain integer as NULL pointer
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3224
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>
> ---
> mm/hugetlb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 222937d512c4..b6c2fc882f21 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -1528,7 +1528,7 @@ static void add_hugetlb_folio(struct hstate *h, struct folio *folio,
> }
>
> folio_set_compound_dtor(folio, HUGETLB_PAGE_DTOR);
> - folio_change_private(folio, 0);
> + folio_change_private(folio, NULL);
> /*
> * We have to set HPageVmemmapOptimized again as above
> * folio_change_private(folio, 0) cleared it.

Reviewed-by: David Hildenbrand <[email protected]>

--
Thanks,

David / dhildenb