2022-11-22 02:17:57

by ye.xingchen

Subject: [PATCH] bus: imx-weim: use devm_platform_get_and_ioremap_resource()

From: Minghao Chi <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Minghao Chi <[email protected]>
Signed-off-by: ye xingchen <[email protected]>
---
drivers/bus/imx-weim.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
index 828c66bbaa67..2a6b4f676458 100644
--- a/drivers/bus/imx-weim.c
+++ b/drivers/bus/imx-weim.c
@@ -263,7 +263,6 @@ static int weim_parse_dt(struct platform_device *pdev)
static int weim_probe(struct platform_device *pdev)
{
struct weim_priv *priv;
- struct resource *res;
struct clk *clk;
void __iomem *base;
int ret;
@@ -273,8 +272,7 @@ static int weim_probe(struct platform_device *pdev)
return -ENOMEM;

/* get the resource */
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- base = devm_ioremap_resource(&pdev->dev, res);
+ base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
if (IS_ERR(base))
return PTR_ERR(base);

--
2.25.1

2022-11-22 09:23:55

by Marco Felsch

Subject: Re: [PATCH] bus: imx-weim: use devm_platform_get_and_ioremap_resource()

Hi Chi,

thanks for your patch.

On 22-11-22, [email protected] wrote:
> From: Minghao Chi <[email protected]>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Minghao Chi <[email protected]>
> Signed-off-by: ye xingchen <[email protected]>

LGTM, feel free to add my

Reviewed-by: Marco Felsch <[email protected]>

> ---
> drivers/bus/imx-weim.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> index 828c66bbaa67..2a6b4f676458 100644
> --- a/drivers/bus/imx-weim.c
> +++ b/drivers/bus/imx-weim.c
> @@ -263,7 +263,6 @@ static int weim_parse_dt(struct platform_device *pdev)
> static int weim_probe(struct platform_device *pdev)
> {
> struct weim_priv *priv;
> - struct resource *res;
> struct clk *clk;
> void __iomem *base;
> int ret;
> @@ -273,8 +272,7 @@ static int weim_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> /* get the resource */
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - base = devm_ioremap_resource(&pdev->dev, res);
> + base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
> if (IS_ERR(base))
> return PTR_ERR(base);
>
> --
> 2.25.1
>
>

2022-12-31 07:58:20

by Shawn Guo

Subject: Re: [PATCH] bus: imx-weim: use devm_platform_get_and_ioremap_resource()

On Tue, Nov 22, 2022 at 09:40:52AM +0800, [email protected] wrote:
> From: Minghao Chi <[email protected]>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Minghao Chi <[email protected]>
> Signed-off-by: ye xingchen <[email protected]>

Applied, thanks!