2022-11-23 04:08:40

by Jiapeng Chong

Subject: [PATCH] ACPI: bus: make osc_sb_ffh_opregion_support_confirmed static

This symbol is not used outside of bus.c, so marks it static.

drivers/acpi/bus.c:304:6: warning: symbol 'osc_sb_ffh_opregion_support_confirmed' was not declared. Should it be static?

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3241
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/acpi/bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index a5ec8120e510..c2effd3f56ab 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -301,7 +301,7 @@ EXPORT_SYMBOL_GPL(osc_sb_native_usb4_support_confirmed);

bool osc_sb_cppc2_support_acked;

-bool osc_sb_ffh_opregion_support_confirmed;
+static bool osc_sb_ffh_opregion_support_confirmed;

static u8 sb_uuid_str[] = "0811B06E-4A27-44F9-8D60-3CBBC22E7B48";
static void acpi_bus_osc_negotiate_platform_control(void)
--
2.20.1.7.g153144c

2022-11-23 10:27:37

by Sudeep Holla

Subject: Re: [PATCH] ACPI: bus: make osc_sb_ffh_opregion_support_confirmed static

On Wed, Nov 23, 2022 at 11:42:15AM +0800, Jiapeng Chong wrote:
> This symbol is not used outside of bus.c, so marks it static.
>
> drivers/acpi/bus.c:304:6: warning: symbol 'osc_sb_ffh_opregion_support_confirmed' was not declared. Should it be static?
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3241
> Reported-by: Abaci Robot <[email protected]>

Sorry for not replying to the original report which I meant to and for some
reason left it in the draft. Anyways in order to fix another bug, this
variable was removed thereby removing this build/sparse warning. This
warning should not appear from today's linux-next.

Thanks for spotting and this patch fixing it.

--
Regards,
Sudeep