2022-11-23 06:55:13

by Jiasheng Jiang

[permalink] [raw]

Subject: [PATCH] can: m_can: Add check for devm_clk_get

---

Since the devm_clk_get may return error,
it should be better to add check for the cdev->hclk,
as same as cdev->cclk.

Fixes: f524f829b75a ("can: m_can: Create a m_can platform framework")
Signed-off-by: Jiasheng Jiang <[email protected]>
---
drivers/net/can/m_can/m_can.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
index 00d11e95fd98..e5575d2755e4 100644
--- a/drivers/net/can/m_can/m_can.c
+++ b/drivers/net/can/m_can/m_can.c
@@ -1909,7 +1909,7 @@ int m_can_class_get_clocks(struct m_can_classdev *cdev)
cdev->hclk = devm_clk_get(cdev->dev, "hclk");
cdev->cclk = devm_clk_get(cdev->dev, "cclk");

- if (IS_ERR(cdev->cclk)) {
+ if (IS_ERR(cdev->hclk) || IS_ERR(cdev->cclk)) {
dev_err(cdev->dev, "no clock found\n");
ret = -ENODEV;
}
--
2.25.1

2022-11-24 14:50:09

by Marc Kleine-Budde

[permalink] [raw]

Subject: Re: [PATCH] can: m_can: Add check for devm_clk_get

---

On 23.11.2022 14:36:51, Jiasheng Jiang wrote:
> Since the devm_clk_get may return error,
> it should be better to add check for the cdev->hclk,
> as same as cdev->cclk.
>
> Fixes: f524f829b75a ("can: m_can: Create a m_can platform framework")
> Signed-off-by: Jiasheng Jiang <[email protected]>

Applied to linux-can.

Thanks,
Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

---

Attachments:

(No filename) (619.00 B)
signature.asc (499.00 B)
Download all attachments