2022-11-23 10:45:58

by Jiapeng Chong

Subject: [PATCH v2] lib/test_rhashtable: Remove set but unused variable 'insert_retries'

Variable 'insert_retries' is not effectively used in the function, so
delete it.

lib/test_rhashtable.c:437:18: warning: variable 'insert_retries' set but not used.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3242
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
Changes in v2:
-The condition for modifying err is less than 0.

lib/test_rhashtable.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/lib/test_rhashtable.c b/lib/test_rhashtable.c
index 6a8e445c8b55..c20f6cb4bf55 100644
--- a/lib/test_rhashtable.c
+++ b/lib/test_rhashtable.c
@@ -434,7 +434,7 @@ static int __init test_rhltable(unsigned int entries)
static int __init test_rhashtable_max(struct test_obj *array,
unsigned int entries)
{
- unsigned int i, insert_retries = 0;
+ unsigned int i;
int err;

test_rht_params.max_size = roundup_pow_of_two(entries / 8);
@@ -447,9 +447,7 @@ static int __init test_rhashtable_max(struct test_obj *array,

obj->value.id = i * 2;
err = insert_retry(&ht, obj, test_rht_params);
- if (err > 0)
- insert_retries += err;
- else if (err)
+ if (err < 0)
return err;
}

--
2.20.1.7.g153144c

2022-11-24 10:18:08

by Herbert Xu

Subject: Re: [PATCH v2] lib/test_rhashtable: Remove set but unused variable 'insert_retries'

On Wed, Nov 23, 2022 at 05:37:02PM +0800, Jiapeng Chong wrote:
> Variable 'insert_retries' is not effectively used in the function, so
> delete it.
>
> lib/test_rhashtable.c:437:18: warning: variable 'insert_retries' set but not used.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3242
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> Changes in v2:
> -The condition for modifying err is less than 0.
>
> lib/test_rhashtable.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)

Acked-by: Herbert Xu <[email protected]>

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2022-11-25 08:38:27

by patchwork-bot+netdevbpf

Subject: Re: [PATCH v2] lib/test_rhashtable: Remove set but unused variable 'insert_retries'

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <[email protected]>:

On Wed, 23 Nov 2022 17:37:02 +0800 you wrote:
> Variable 'insert_retries' is not effectively used in the function, so
> delete it.
>
> lib/test_rhashtable.c:437:18: warning: variable 'insert_retries' set but not used.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3242
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
>
> [...]

Here is the summary with links:
- [v2] lib/test_rhashtable: Remove set but unused variable 'insert_retries'
https://git.kernel.org/netdev/net-next/c/b084f6cc3563

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html