Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
is possible to test-build any driver which depends on OF on any
architecture by explicitly selecting OF. Therefore depending on
COMPILE_TEST as an alternative is no longer needed.
It is actually better to always build such drivers with OF enabled,
so that the test builds are closer to how each driver will actually be
built on its intended target. Building them without OF may not test
much as the compiler will optimize out potentially large parts of the
code. In the worst case, this could even pop false positive warnings.
Dropping COMPILE_TEST here improves the quality of our testing and
avoids wasting time on non-existent issues.
As a minor optimization, this also lets us drop of_match_ptr(), as we
now know what it will resolve to, we might as well save cpp some work.
Signed-off-by: Jean Delvare <[email protected]>
Cc: Peter Rosin <[email protected]>
---
drivers/mux/Kconfig | 2 +-
drivers/mux/mmio.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--- linux-6.0.orig/drivers/mux/Kconfig
+++ linux-6.0/drivers/mux/Kconfig
@@ -47,7 +47,7 @@ config MUX_GPIO
config MUX_MMIO
tristate "MMIO/Regmap register bitfield-controlled Multiplexer"
- depends on OF || COMPILE_TEST
+ depends on OF
help
MMIO/Regmap register bitfield-controlled Multiplexer controller.
--- linux-6.0.orig/drivers/mux/mmio.c
+++ linux-6.0/drivers/mux/mmio.c
@@ -131,7 +131,7 @@ static int mux_mmio_probe(struct platfor
static struct platform_driver mux_mmio_driver = {
.driver = {
.name = "mmio-mux",
- .of_match_table = of_match_ptr(mux_mmio_dt_ids),
+ .of_match_table = mux_mmio_dt_ids,
},
.probe = mux_mmio_probe,
};
--
Jean Delvare
SUSE L3 Support
Hi!
2022-11-24 at 13:37, Jean Delvare wrote:
> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
>
> It is actually better to always build such drivers with OF enabled,
> so that the test builds are closer to how each driver will actually be
> built on its intended target. Building them without OF may not test
> much as the compiler will optimize out potentially large parts of the
> code. In the worst case, this could even pop false positive warnings.
> Dropping COMPILE_TEST here improves the quality of our testing and
> avoids wasting time on non-existent issues.
>
> As a minor optimization, this also lets us drop of_match_ptr(), as we
> now know what it will resolve to, we might as well save cpp some work.
>
> Signed-off-by: Jean Delvare <[email protected]>
> Cc: Peter Rosin <[email protected]>
Yes, entirely reasonable. I have pushed this out to the mux for-next
branch. That said, it's probably a bit late for the upcoming merge
window...
Cheers,
Peter
> ---
> drivers/mux/Kconfig | 2 +-
> drivers/mux/mmio.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-6.0.orig/drivers/mux/Kconfig
> +++ linux-6.0/drivers/mux/Kconfig
> @@ -47,7 +47,7 @@ config MUX_GPIO
>
> config MUX_MMIO
> tristate "MMIO/Regmap register bitfield-controlled Multiplexer"
> - depends on OF || COMPILE_TEST
> + depends on OF
> help
> MMIO/Regmap register bitfield-controlled Multiplexer controller.
>
> --- linux-6.0.orig/drivers/mux/mmio.c
> +++ linux-6.0/drivers/mux/mmio.c
> @@ -131,7 +131,7 @@ static int mux_mmio_probe(struct platfor
> static struct platform_driver mux_mmio_driver = {
> .driver = {
> .name = "mmio-mux",
> - .of_match_table = of_match_ptr(mux_mmio_dt_ids),
> + .of_match_table = mux_mmio_dt_ids,
> },
> .probe = mux_mmio_probe,
> };
>
>