2022-11-25 07:16:41

by zhangpeng (AS)

Subject: [PATCH] pinctrl: pinconf-generic: add missing of_node_put() in pinconf_generic_dt_node_to_map()

From: ZhangPeng <[email protected]>

of_node_put() needs to be called when jumping out of the loop, since
for_each_available_child_of_node() will increase the refcount of node.

Fixes: c7289500e29d ("pinctrl: pinconf-generic: scan also referenced phandle node")
Signed-off-by: ZhangPeng <[email protected]>
---
drivers/pinctrl/pinconf-generic.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinconf-generic.c b/drivers/pinctrl/pinconf-generic.c
index 415d1df8f46a..365c4b0ca465 100644
--- a/drivers/pinctrl/pinconf-generic.c
+++ b/drivers/pinctrl/pinconf-generic.c
@@ -395,8 +395,10 @@ int pinconf_generic_dt_node_to_map(struct pinctrl_dev *pctldev,
for_each_available_child_of_node(np_config, np) {
ret = pinconf_generic_dt_subnode_to_map(pctldev, np, map,
&reserved_maps, num_maps, type);
- if (ret < 0)
+ if (ret < 0) {
+ of_node_put(np);
goto exit;
+ }
}
return 0;

--
2.25.1

2022-11-25 10:38:04

by Linus Walleij

Subject: Re: [PATCH] pinctrl: pinconf-generic: add missing of_node_put() in pinconf_generic_dt_node_to_map()

On Fri, Nov 25, 2022 at 8:02 AM Peng Zhang <[email protected]> wrote:

> From: ZhangPeng <[email protected]>
>
> of_node_put() needs to be called when jumping out of the loop, since
> for_each_available_child_of_node() will increase the refcount of node.
>
> Fixes: c7289500e29d ("pinctrl: pinconf-generic: scan also referenced phandle node")
> Signed-off-by: ZhangPeng <[email protected]>

Good catch!
Patch applied.

Yours,
Linus Walleij