2022-11-19 01:00:25

by Uwe Kleine-König

Subject: [PATCH 487/606] misc: eeprom/eeprom: Convert to i2c's .probe_new()

From: Uwe Kleine-König <[email protected]>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/misc/eeprom/eeprom.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/misc/eeprom/eeprom.c b/drivers/misc/eeprom/eeprom.c
index 8a841a75d893..32611100d5cd 100644
--- a/drivers/misc/eeprom/eeprom.c
+++ b/drivers/misc/eeprom/eeprom.c
@@ -141,8 +141,7 @@ static int eeprom_detect(struct i2c_client *client, struct i2c_board_info *info)
return 0;
}

-static int eeprom_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int eeprom_probe(struct i2c_client *client)
{
struct i2c_adapter *adapter = client->adapter;
struct eeprom_data *data;
@@ -197,7 +196,7 @@ static struct i2c_driver eeprom_driver = {
.driver = {
.name = "eeprom",
},
- .probe = eeprom_probe,
+ .probe_new = eeprom_probe,
.remove = eeprom_remove,
.id_table = eeprom_id,

--
2.38.1

2022-11-28 15:00:32

by Jean Delvare

Subject: Re: [PATCH 487/606] misc: eeprom/eeprom: Convert to i2c's .probe_new()

On Fri, 18 Nov 2022 23:43:41 +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <[email protected]>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>
> ---
> drivers/misc/eeprom/eeprom.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/misc/eeprom/eeprom.c b/drivers/misc/eeprom/eeprom.c
> index 8a841a75d893..32611100d5cd 100644
> --- a/drivers/misc/eeprom/eeprom.c
> +++ b/drivers/misc/eeprom/eeprom.c
> @@ -141,8 +141,7 @@ static int eeprom_detect(struct i2c_client *client, struct i2c_board_info *info)
> return 0;
> }
>
> -static int eeprom_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int eeprom_probe(struct i2c_client *client)
> {
> struct i2c_adapter *adapter = client->adapter;
> struct eeprom_data *data;
> @@ -197,7 +196,7 @@ static struct i2c_driver eeprom_driver = {
> .driver = {
> .name = "eeprom",
> },
> - .probe = eeprom_probe,
> + .probe_new = eeprom_probe,
> .remove = eeprom_remove,
> .id_table = eeprom_id,
>

Reviewed-by: Jean Delvare <[email protected]>

--
Jean Delvare
SUSE L3 Support