From: Yushan Zhou <[email protected]>
Fix the following coccicheck warning:
./drivers/gpu/host1x/fence.c:97:2-7: WARNING:
NULL check before some freeing functions is not needed.
Signed-off-by: Yushan Zhou <[email protected]>
---
drivers/gpu/host1x/fence.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/host1x/fence.c b/drivers/gpu/host1x/fence.c
index ecab72882192..05b36bfc8b74 100644
--- a/drivers/gpu/host1x/fence.c
+++ b/drivers/gpu/host1x/fence.c
@@ -93,8 +93,7 @@ static void host1x_syncpt_fence_release(struct dma_fence *f)
{
struct host1x_syncpt_fence *sf = to_host1x_fence(f);
- if (sf->waiter)
- kfree(sf->waiter);
+ kfree(sf->waiter);
dma_fence_free(f);
}
--
2.27.0
+ Thierry Reding, linux-tegra, dri-devel
On Tue, Nov 29, 2022 at 04:43:29PM +0800, [email protected] wrote:
> From: Yushan Zhou <[email protected]>
>
> Fix the following coccicheck warning:
> ./drivers/gpu/host1x/fence.c:97:2-7: WARNING:
> NULL check before some freeing functions is not needed.
>
> Signed-off-by: Yushan Zhou <[email protected]>
Hi,
the change in the patch looks good to me.
However, it does not appear to be a networking patch,
so I think you have sent it to the wrong place.
With reference to:
$ ./scripts/get_maintainer.pl drivers/gpu/host1x/fence.c
Thierry Reding <[email protected]> (supporter:DRM DRIVERS FOR NVIDIA TEGRA)
David Airlie <[email protected]> (maintainer:DRM DRIVERS)
Daniel Vetter <[email protected]> (maintainer:DRM DRIVERS)
Sumit Semwal <[email protected]> (maintainer:DMA BUFFER SHARING FRAMEWORK)
"Christian König" <[email protected]> (maintainer:DMA BUFFER SHARING FRAMEWORK)
[email protected] (open list:DRM DRIVERS FOR NVIDIA TEGRA)
[email protected] (open list:DRM DRIVERS FOR NVIDIA TEGRA)
[email protected] (open list)
[email protected] (open list:DMA BUFFER SHARING FRAMEWORK)
[email protected] (moderated list:DMA BUFFER SHARING FRAMEWORK)
And https://lore.kernel.org/dri-devel/39c44dce203112a8dfe279e8e2c4ad164e3cf5e5.1666275461.git.robin.murphy@arm.com/
I would suggest that the patch subject should be:
[PATCH] gpu: host1x: Remove redundant null check before kfree
And you should send it:
To: Thierry Reding <[email protected]>
Cc: [email protected], [email protected]
> ---
> drivers/gpu/host1x/fence.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/host1x/fence.c b/drivers/gpu/host1x/fence.c
> index ecab72882192..05b36bfc8b74 100644
> --- a/drivers/gpu/host1x/fence.c
> +++ b/drivers/gpu/host1x/fence.c
> @@ -93,8 +93,7 @@ static void host1x_syncpt_fence_release(struct dma_fence *f)
> {
> struct host1x_syncpt_fence *sf = to_host1x_fence(f);
>
> - if (sf->waiter)
> - kfree(sf->waiter);
> + kfree(sf->waiter);
>
> dma_fence_free(f);
> }
> --
> 2.27.0
>
On Wed, Nov 30, 2022 at 9:57 PM Simon Horman <[email protected]> wrote:
>
> + Thierry Reding, linux-tegra, dri-devel
>
> On Tue, Nov 29, 2022 at 04:43:29PM +0800, [email protected] wrote:
> > From: Yushan Zhou <[email protected]>
> >
> > Fix the following coccicheck warning:
> > ./drivers/gpu/host1x/fence.c:97:2-7: WARNING:
> > NULL check before some freeing functions is not needed.
> >
> > Signed-off-by: Yushan Zhou <[email protected]>
>
> Hi,
>
> the change in the patch looks good to me.
> However, it does not appear to be a networking patch,
> so I think you have sent it to the wrong place.
>
> With reference to:
>
> $ ./scripts/get_maintainer.pl drivers/gpu/host1x/fence.c
> Thierry Reding <[email protected]> (supporter:DRM DRIVERS FOR NVIDIA TEGRA)
> David Airlie <[email protected]> (maintainer:DRM DRIVERS)
> Daniel Vetter <[email protected]> (maintainer:DRM DRIVERS)
> Sumit Semwal <[email protected]> (maintainer:DMA BUFFER SHARING FRAMEWORK)
> "Christian König" <[email protected]> (maintainer:DMA BUFFER SHARING FRAMEWORK)
> [email protected] (open list:DRM DRIVERS FOR NVIDIA TEGRA)
> [email protected] (open list:DRM DRIVERS FOR NVIDIA TEGRA)
> [email protected] (open list)
> [email protected] (open list:DMA BUFFER SHARING FRAMEWORK)
> [email protected] (moderated list:DMA BUFFER SHARING FRAMEWORK)
>
> And https://lore.kernel.org/dri-devel/39c44dce203112a8dfe279e8e2c4ad164e3cf5e5.1666275461.git.robin.murphy@arm.com/
>
> I would suggest that the patch subject should be:
>
> [PATCH] gpu: host1x: Remove redundant null check before kfree
>
> And you should send it:
>
> To: Thierry Reding <[email protected]>
> Cc: [email protected], [email protected]
>
> > ---
> > drivers/gpu/host1x/fence.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/host1x/fence.c b/drivers/gpu/host1x/fence.c
> > index ecab72882192..05b36bfc8b74 100644
> > --- a/drivers/gpu/host1x/fence.c
> > +++ b/drivers/gpu/host1x/fence.c
> > @@ -93,8 +93,7 @@ static void host1x_syncpt_fence_release(struct dma_fence *f)
> > {
> > struct host1x_syncpt_fence *sf = to_host1x_fence(f);
> >
> > - if (sf->waiter)
> > - kfree(sf->waiter);
> > + kfree(sf->waiter);
> >
> > dma_fence_free(f);
> > }
> > --
> > 2.27.0
> >
Apologies for the mistake... I'll resend it to the correct place.
Thanks for your reminder, anyway.
Best,
Katrin