2022-12-05 04:02:23

by ye.xingchen

Subject: [PATCH linux-next] rtc: ds1307: use sysfs_emit() to instead of scnprintf()

From: ye xingchen <[email protected]>

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen <[email protected]>
---
drivers/rtc/rtc-ds1307.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
index 7c2276cf5514..def9b7f9d957 100644
--- a/drivers/rtc/rtc-ds1307.c
+++ b/drivers/rtc/rtc-ds1307.c
@@ -1219,8 +1219,7 @@ static ssize_t frequency_test_show(struct device *dev,

regmap_read(ds1307->regmap, M41TXX_REG_CONTROL, &ctrl_reg);

- return scnprintf(buf, PAGE_SIZE, (ctrl_reg & M41TXX_BIT_FT) ? "on\n" :
- "off\n");
+ return sysfs_emit(buf, (ctrl_reg & M41TXX_BIT_FT) ? "on\n" : "off\n");
}

static DEVICE_ATTR_RW(frequency_test);
--
2.25.1

2022-12-13 00:17:54

by Alexandre Belloni

Subject: Re: [PATCH linux-next] rtc: ds1307: use sysfs_emit() to instead of scnprintf()

On Mon, 5 Dec 2022 11:34:45 +0800 (CST), [email protected] wrote:
> From: ye xingchen <[email protected]>
>
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
>
>
> [...]

Applied, thanks!

[1/1] rtc: ds1307: use sysfs_emit() to instead of scnprintf()
commit: 20ff2be9cf5c1951e5a14e570129cf118039a25a

Best regards,

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com