2022-11-19 00:00:14

by Uwe Kleine-König

Subject: [PATCH 222/606] Input: synaptics_i2c - Convert to i2c's .probe_new()

From: Uwe Kleine-König <[email protected]>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/input/mouse/synaptics_i2c.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/input/mouse/synaptics_i2c.c b/drivers/input/mouse/synaptics_i2c.c
index 987ee67a1045..6487c8c60d5e 100644
--- a/drivers/input/mouse/synaptics_i2c.c
+++ b/drivers/input/mouse/synaptics_i2c.c
@@ -521,8 +521,7 @@ static struct synaptics_i2c *synaptics_i2c_touch_create(struct i2c_client *clien
return touch;
}

-static int synaptics_i2c_probe(struct i2c_client *client,
- const struct i2c_device_id *dev_id)
+static int synaptics_i2c_probe(struct i2c_client *client)
{
int ret;
struct synaptics_i2c *touch;
@@ -651,7 +650,7 @@ static struct i2c_driver synaptics_i2c_driver = {
.pm = &synaptics_i2c_pm,
},

- .probe = synaptics_i2c_probe,
+ .probe_new = synaptics_i2c_probe,
.remove = synaptics_i2c_remove,

.id_table = synaptics_i2c_id_table,
--
2.38.1

2022-12-06 11:25:08

by Jean Delvare

Subject: Re: [PATCH 222/606] Input: synaptics_i2c - Convert to i2c's .probe_new()

On Fri, 18 Nov 2022 23:39:16 +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <[email protected]>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>
> ---
> drivers/input/mouse/synaptics_i2c.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/input/mouse/synaptics_i2c.c b/drivers/input/mouse/synaptics_i2c.c
> index 987ee67a1045..6487c8c60d5e 100644
> --- a/drivers/input/mouse/synaptics_i2c.c
> +++ b/drivers/input/mouse/synaptics_i2c.c
> @@ -521,8 +521,7 @@ static struct synaptics_i2c *synaptics_i2c_touch_create(struct i2c_client *clien
> return touch;
> }
>
> -static int synaptics_i2c_probe(struct i2c_client *client,
> - const struct i2c_device_id *dev_id)
> +static int synaptics_i2c_probe(struct i2c_client *client)
> {
> int ret;
> struct synaptics_i2c *touch;
> @@ -651,7 +650,7 @@ static struct i2c_driver synaptics_i2c_driver = {
> .pm = &synaptics_i2c_pm,
> },
>
> - .probe = synaptics_i2c_probe,
> + .probe_new = synaptics_i2c_probe,
> .remove = synaptics_i2c_remove,
>
> .id_table = synaptics_i2c_id_table,

Reviewed-by: Jean Delvare <[email protected]>

--
Jean Delvare
SUSE L3 Support