2022-12-07 12:23:55

by Lai Jiangshan

Subject: [PATCH] kvm: Remove the unused macro KVM_MMU_READ_LOCK()

From: Lai Jiangshan <[email protected]>

No code is using KVM_MMU_READ_LOCK().

Signed-off-by: Lai Jiangshan <[email protected]>
---
virt/kvm/kvm_mm.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/virt/kvm/kvm_mm.h b/virt/kvm/kvm_mm.h
index a1ab15006af3..e98e294080bf 100644
--- a/virt/kvm/kvm_mm.h
+++ b/virt/kvm/kvm_mm.h
@@ -14,13 +14,11 @@
#define KVM_MMU_LOCK_INIT(kvm) rwlock_init(&(kvm)->mmu_lock)
#define KVM_MMU_LOCK(kvm) write_lock(&(kvm)->mmu_lock)
#define KVM_MMU_UNLOCK(kvm) write_unlock(&(kvm)->mmu_lock)
-#define KVM_MMU_READ_LOCK(kvm) read_lock(&(kvm)->mmu_lock)
#define KVM_MMU_READ_UNLOCK(kvm) read_unlock(&(kvm)->mmu_lock)
#else
#define KVM_MMU_LOCK_INIT(kvm) spin_lock_init(&(kvm)->mmu_lock)
#define KVM_MMU_LOCK(kvm) spin_lock(&(kvm)->mmu_lock)
#define KVM_MMU_UNLOCK(kvm) spin_unlock(&(kvm)->mmu_lock)
-#define KVM_MMU_READ_LOCK(kvm) spin_lock(&(kvm)->mmu_lock)
#define KVM_MMU_READ_UNLOCK(kvm) spin_unlock(&(kvm)->mmu_lock)
#endif /* KVM_HAVE_MMU_RWLOCK */

--
2.19.1.6.gb485710b

2022-12-09 08:41:48

by Paolo Bonzini

Subject: Re: [PATCH] kvm: Remove the unused macro KVM_MMU_READ_LOCK()

On 12/7/22 13:06, Lai Jiangshan wrote:
> From: Lai Jiangshan <[email protected]>
>
> No code is using KVM_MMU_READ_LOCK().

And KVM_MMU_READ_UNLOCK() is also unused.

Paolo

> Signed-off-by: Lai Jiangshan <[email protected]>
> ---
> virt/kvm/kvm_mm.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/virt/kvm/kvm_mm.h b/virt/kvm/kvm_mm.h
> index a1ab15006af3..e98e294080bf 100644
> --- a/virt/kvm/kvm_mm.h
> +++ b/virt/kvm/kvm_mm.h
> @@ -14,13 +14,11 @@
> #define KVM_MMU_LOCK_INIT(kvm) rwlock_init(&(kvm)->mmu_lock)
> #define KVM_MMU_LOCK(kvm) write_lock(&(kvm)->mmu_lock)
> #define KVM_MMU_UNLOCK(kvm) write_unlock(&(kvm)->mmu_lock)
> -#define KVM_MMU_READ_LOCK(kvm) read_lock(&(kvm)->mmu_lock)
> #define KVM_MMU_READ_UNLOCK(kvm) read_unlock(&(kvm)->mmu_lock)
> #else
> #define KVM_MMU_LOCK_INIT(kvm) spin_lock_init(&(kvm)->mmu_lock)
> #define KVM_MMU_LOCK(kvm) spin_lock(&(kvm)->mmu_lock)
> #define KVM_MMU_UNLOCK(kvm) spin_unlock(&(kvm)->mmu_lock)
> -#define KVM_MMU_READ_LOCK(kvm) spin_lock(&(kvm)->mmu_lock)
> #define KVM_MMU_READ_UNLOCK(kvm) spin_unlock(&(kvm)->mmu_lock)
> #endif /* KVM_HAVE_MMU_RWLOCK */
>