2022-12-07 08:10:03

by ye.xingchen

Subject: [PATCH] iio: magnetometer: bmc150_magn: Convert to use sysfs_emit_at() API

From: ye xingchen <[email protected]>

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen <[email protected]>
---
drivers/iio/magnetometer/bmc150_magn.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iio/magnetometer/bmc150_magn.c b/drivers/iio/magnetometer/bmc150_magn.c
index 06d5a1ef1fbd..1398684a7f30 100644
--- a/drivers/iio/magnetometer/bmc150_magn.c
+++ b/drivers/iio/magnetometer/bmc150_magn.c
@@ -598,8 +598,7 @@ static ssize_t bmc150_magn_show_samp_freq_avail(struct device *dev,
for (i = 0; i < ARRAY_SIZE(bmc150_magn_samp_freq_table); i++) {
if (bmc150_magn_samp_freq_table[i].freq > data->max_odr)
break;
- len += scnprintf(buf + len, PAGE_SIZE - len, "%d ",
- bmc150_magn_samp_freq_table[i].freq);
+ len += sysfs_emit_at(buf, len, "%d ", bmc150_magn_samp_freq_table[i].freq);
}
/* replace last space with a newline */
buf[len - 1] = '\n';
--
2.25.1

2022-12-07 09:20:12

by Andy Shevchenko

Subject: Re: [PATCH] iio: magnetometer: bmc150_magn: Convert to use sysfs_emit_at() API

On Wed, Dec 7, 2022 at 9:49 AM <[email protected]> wrote:
>
> From: ye xingchen <[email protected]>
>
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.

Reviewed-by: Andy Shevchenko <[email protected]>

> Signed-off-by: ye xingchen <[email protected]>
> ---
> drivers/iio/magnetometer/bmc150_magn.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iio/magnetometer/bmc150_magn.c b/drivers/iio/magnetometer/bmc150_magn.c
> index 06d5a1ef1fbd..1398684a7f30 100644
> --- a/drivers/iio/magnetometer/bmc150_magn.c
> +++ b/drivers/iio/magnetometer/bmc150_magn.c
> @@ -598,8 +598,7 @@ static ssize_t bmc150_magn_show_samp_freq_avail(struct device *dev,
> for (i = 0; i < ARRAY_SIZE(bmc150_magn_samp_freq_table); i++) {
> if (bmc150_magn_samp_freq_table[i].freq > data->max_odr)
> break;
> - len += scnprintf(buf + len, PAGE_SIZE - len, "%d ",
> - bmc150_magn_samp_freq_table[i].freq);
> + len += sysfs_emit_at(buf, len, "%d ", bmc150_magn_samp_freq_table[i].freq);
> }
> /* replace last space with a newline */
> buf[len - 1] = '\n';
> --
> 2.25.1



--
With Best Regards,
Andy Shevchenko

2022-12-11 12:57:05

by Jonathan Cameron

Subject: Re: [PATCH] iio: magnetometer: bmc150_magn: Convert to use sysfs_emit_at() API

On Wed, 7 Dec 2022 10:46:14 +0200
Andy Shevchenko <[email protected]> wrote:

> On Wed, Dec 7, 2022 at 9:49 AM <[email protected]> wrote:
> >
> > From: ye xingchen <[email protected]>
> >
> > Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> > should only use sysfs_emit() or sysfs_emit_at() when formatting the
> > value to be returned to user space.
>
> Reviewed-by: Andy Shevchenko <[email protected]>
>
> > Signed-off-by: ye xingchen <[email protected]>
> > ---
> > drivers/iio/magnetometer/bmc150_magn.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/magnetometer/bmc150_magn.c b/drivers/iio/magnetometer/bmc150_magn.c
> > index 06d5a1ef1fbd..1398684a7f30 100644
> > --- a/drivers/iio/magnetometer/bmc150_magn.c
> > +++ b/drivers/iio/magnetometer/bmc150_magn.c
> > @@ -598,8 +598,7 @@ static ssize_t bmc150_magn_show_samp_freq_avail(struct device *dev,
> > for (i = 0; i < ARRAY_SIZE(bmc150_magn_samp_freq_table); i++) {
> > if (bmc150_magn_samp_freq_table[i].freq > data->max_odr)
> > break;
> > - len += scnprintf(buf + len, PAGE_SIZE - len, "%d ",
> > - bmc150_magn_samp_freq_table[i].freq);
> > + len += sysfs_emit_at(buf, len, "%d ", bmc150_magn_samp_freq_table[i].freq);
> > }

I'd prefer we keep the line break before the last parameter.

Generally in IIO at least, preference is for < 80 chars except where readability is
significantly enhanced by a longer line. That's not true in this case.

Jonathan


> > /* replace last space with a newline */
> > buf[len - 1] = '\n';
> > --
> > 2.25.1
>
>
>