2022-12-12 03:54:46

by Jiapeng Chong

Subject: [PATCH] dmaengine: idxd: Remove the unused function set_completion_address()

The function set_completion_address is defined in the dma.c file, but not
called elsewhere, so remove this unused function.

drivers/dma/idxd/dma.c:66:20: warning: unused function 'set_completion_address'.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3416
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/dma/idxd/dma.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/dma/idxd/dma.c b/drivers/dma/idxd/dma.c
index e0874cb4721c..eb35ca313684 100644
--- a/drivers/dma/idxd/dma.c
+++ b/drivers/dma/idxd/dma.c
@@ -63,12 +63,6 @@ static void op_flag_setup(unsigned long flags, u32 *desc_flags)
*desc_flags |= IDXD_OP_FLAG_RCI;
}

-static inline void set_completion_address(struct idxd_desc *desc,
- u64 *compl_addr)
-{
- *compl_addr = desc->compl_dma;
-}
-
static inline void idxd_prep_desc_common(struct idxd_wq *wq,
struct dsa_hw_desc *hw, char opcode,
u64 addr_f1, u64 addr_f2, u64 len,
--
2.20.1.7.g153144c

2022-12-12 15:38:36

by Dave Jiang

Subject: Re: [PATCH] dmaengine: idxd: Remove the unused function set_completion_address()

On 12/11/2022 8:35 PM, Jiapeng Chong wrote:
> The function set_completion_address is defined in the dma.c file, but not
> called elsewhere, so remove this unused function.
>
> drivers/dma/idxd/dma.c:66:20: warning: unused function 'set_completion_address'.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3416
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

Acked-by: Dave Jiang <[email protected]>
Thanks for the cleanup
> ---
> drivers/dma/idxd/dma.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/dma/idxd/dma.c b/drivers/dma/idxd/dma.c
> index e0874cb4721c..eb35ca313684 100644
> --- a/drivers/dma/idxd/dma.c
> +++ b/drivers/dma/idxd/dma.c
> @@ -63,12 +63,6 @@ static void op_flag_setup(unsigned long flags, u32 *desc_flags)
> *desc_flags |= IDXD_OP_FLAG_RCI;
> }
>
> -static inline void set_completion_address(struct idxd_desc *desc,
> - u64 *compl_addr)
> -{
> - *compl_addr = desc->compl_dma;
> -}
> -
> static inline void idxd_prep_desc_common(struct idxd_wq *wq,
> struct dsa_hw_desc *hw, char opcode,
> u64 addr_f1, u64 addr_f2, u64 len,

2022-12-28 07:03:17

by Vinod Koul

Subject: Re: [PATCH] dmaengine: idxd: Remove the unused function set_completion_address()

On 12-12-22, 11:35, Jiapeng Chong wrote:
> The function set_completion_address is defined in the dma.c file, but not
> called elsewhere, so remove this unused function.

Applied, thanks

--
~Vinod