2022-12-10 02:44:00

by Miaohe Lin

Subject: [PATCH] writeback: remove obsolete macro EXPIRE_DIRTY_ATIME

EXPIRE_DIRTY_ATIME is not used anymore. Remove it.

Signed-off-by: Miaohe Lin <[email protected]>
---
fs/fs-writeback.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index 9958d4020771..6bad645ac36f 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -1345,8 +1345,6 @@ static bool inode_dirtied_after(struct inode *inode, unsigned long t)
return ret;
}

-#define EXPIRE_DIRTY_ATIME 0x0001
-
/*
* Move expired (dirtied before dirtied_before) dirty inodes from
* @delaying_queue to @dispatch_queue.
--
2.27.0

2022-12-12 14:15:44

by Jan Kara

Subject: Re: [PATCH] writeback: remove obsolete macro EXPIRE_DIRTY_ATIME

On Sat 10-12-22 18:10:42, Miaohe Lin wrote:
> EXPIRE_DIRTY_ATIME is not used anymore. Remove it.
>
> Signed-off-by: Miaohe Lin <[email protected]>

Sure. Thanks! Feel free to add:

Reviewed-by: Jan Kara <[email protected]>

Honza

> ---
> fs/fs-writeback.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index 9958d4020771..6bad645ac36f 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -1345,8 +1345,6 @@ static bool inode_dirtied_after(struct inode *inode, unsigned long t)
> return ret;
> }
>
> -#define EXPIRE_DIRTY_ATIME 0x0001
> -
> /*
> * Move expired (dirtied before dirtied_before) dirty inodes from
> * @delaying_queue to @dispatch_queue.
> --
> 2.27.0
>
--
Jan Kara <[email protected]>
SUSE Labs, CR

2022-12-12 20:14:00

by Jens Axboe

Subject: Re: [PATCH] writeback: remove obsolete macro EXPIRE_DIRTY_ATIME

On Sat, 10 Dec 2022 18:10:42 +0800, Miaohe Lin wrote:
> EXPIRE_DIRTY_ATIME is not used anymore. Remove it.
>
>

Applied, thanks!

[1/1] writeback: remove obsolete macro EXPIRE_DIRTY_ATIME
commit: 23e188a16423a6e65290abf39dd427ff047e6843

Best regards,
--
Jens Axboe

2022-12-13 02:54:06

by Miaohe Lin

Subject: Re: [PATCH] writeback: remove obsolete macro EXPIRE_DIRTY_ATIME

On 2022/12/13 4:08, Jens Axboe wrote:
>
> On Sat, 10 Dec 2022 18:10:42 +0800, Miaohe Lin wrote:
>> EXPIRE_DIRTY_ATIME is not used anymore. Remove it.
>>
>>
>
> Applied, thanks!
>
> [1/1] writeback: remove obsolete macro EXPIRE_DIRTY_ATIME
> commit: 23e188a16423a6e65290abf39dd427ff047e6843
>
> Best regards,

Many thanks both for quick respond in such busy days. :)

Thanks,
Miaohe Lin