2022-12-13 19:42:10

by SeongJae Park

[permalink] [raw]
Subject: Re: [PATCH -next 8/8] mm: damon: remove unneed damon_get_page()

Hi Kefeng,

On Tue, 13 Dec 2022 17:27:35 +0800 Kefeng Wang <[email protected]> wrote:

> After all damon_get_page() callers are converted to damon_get_folio(),
> remove unneed wrapper damon_get_page().
>
> Signed-off-by: Kefeng Wang <[email protected]>
> ---
> mm/damon/ops-common.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/mm/damon/ops-common.h b/mm/damon/ops-common.h
> index 4ee607813981..35a2e42a27da 100644
> --- a/mm/damon/ops-common.h
> +++ b/mm/damon/ops-common.h
> @@ -8,13 +8,6 @@
> #include <linux/damon.h>
>
> struct folio *damon_get_folio(unsigned long pfn);
> -static inline struct page *damon_get_page(unsigned long pfn)
> -{
> - struct folio *folio = damon_get_folio(pfn);
> -
> - return &folio->page;
> -}
> -
> void damon_ptep_mkold(pte_t *pte, struct mm_struct *mm, unsigned long addr);

Let's keep the one blank line before damon_ptep_mkold().

> void damon_pmdp_mkold(pmd_t *pmd, struct mm_struct *mm, unsigned long addr);
>
> --
> 2.35.3

Thanks,
SJ