2022-12-14 14:07:26

by Zenghui Yu

[permalink] [raw]
Subject: [PATCH] arm64: ptrace: Use ARM64_SME to guard the SME register enumerations

We currently guard REGSET_{SSVE, ZA} using ARM64_SVE for no good reason.
Both enumerations would be pointless without ARM64_SME and create two empty
entries in aarch64_regsets[] which would then become part of a process's
native regset view (they should be ignored though).

Switch to use ARM64_SME instead.

Fixes: e12310a0d30f ("arm64/sme: Implement ptrace support for streaming mode SVE registers")
Signed-off-by: Zenghui Yu <[email protected]>
---
arch/arm64/kernel/ptrace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kernel/ptrace.c b/arch/arm64/kernel/ptrace.c
index 2686ab157601..0c321ad23cd3 100644
--- a/arch/arm64/kernel/ptrace.c
+++ b/arch/arm64/kernel/ptrace.c
@@ -1357,7 +1357,7 @@ enum aarch64_regset {
#ifdef CONFIG_ARM64_SVE
REGSET_SVE,
#endif
-#ifdef CONFIG_ARM64_SVE
+#ifdef CONFIG_ARM64_SME
REGSET_SSVE,
REGSET_ZA,
#endif
--
2.33.0


2022-12-14 15:30:17

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] arm64: ptrace: Use ARM64_SME to guard the SME register enumerations

On Wed, Dec 14, 2022 at 09:59:43PM +0800, Zenghui Yu wrote:
> We currently guard REGSET_{SSVE, ZA} using ARM64_SVE for no good reason.
> Both enumerations would be pointless without ARM64_SME and create two empty
> entries in aarch64_regsets[] which would then become part of a process's
> native regset view (they should be ignored though).
>
> Switch to use ARM64_SME instead.

Reviewed-by: Mark Brown <[email protected]>


Attachments:
(No filename) (435.00 B)
signature.asc (499.00 B)
Download all attachments

2023-01-05 18:44:28

by Will Deacon

[permalink] [raw]
Subject: Re: [PATCH] arm64: ptrace: Use ARM64_SME to guard the SME register enumerations

On Wed, 14 Dec 2022 21:59:43 +0800, Zenghui Yu wrote:
> We currently guard REGSET_{SSVE, ZA} using ARM64_SVE for no good reason.
> Both enumerations would be pointless without ARM64_SME and create two empty
> entries in aarch64_regsets[] which would then become part of a process's
> native regset view (they should be ignored though).
>
> Switch to use ARM64_SME instead.
>
> [...]

Applied to arm64 (for-next/fixes), thanks!

[1/1] arm64: ptrace: Use ARM64_SME to guard the SME register enumerations
https://git.kernel.org/arm64/c/eb9a85261e29

Cheers,
--
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev