2022-12-28 12:41:28

by Hari Nagalla

Subject: [PATCH 2/2] remoteproc: k3-c7x: Add support for C7xv DSP on AM62A SoC

Add support to the K3 DSP remoteproc driver to configure the C7xv
subsystem core on AM62A SoCs. The C7xv susbsytem is based on C71 DSP
with anlytics engine for deep leraning purposes. The remoteproc
handling for device management is similar to the C66/C71 DSPs on K3
J7 family SoCs, even though there are additional hardware accelerators
and IP updates to C7xv subsystem.

Signed-off-by: Hari Nagalla <[email protected]>
Signed-off-by: Jai Luthra <[email protected]>
---
drivers/remoteproc/ti_k3_dsp_remoteproc.c | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/drivers/remoteproc/ti_k3_dsp_remoteproc.c b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
index eb9c64f7b9b4..ec626a37fef6 100644
--- a/drivers/remoteproc/ti_k3_dsp_remoteproc.c
+++ b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
@@ -870,6 +870,10 @@ static const struct k3_dsp_mem_data c71_mems[] = {
{ .name = "l1dram", .dev_addr = 0xe00000 },
};

+static const struct k3_dsp_mem_data c7xv_mems[] = {
+ { .name = "l2sram", .dev_addr = 0x800000 },
+};
+
static const struct k3_dsp_dev_data c66_data = {
.mems = c66_mems,
.num_mems = ARRAY_SIZE(c66_mems),
@@ -884,10 +888,18 @@ static const struct k3_dsp_dev_data c71_data = {
.uses_lreset = false,
};

+static const struct k3_dsp_dev_data c7xv_data = {
+ .mems = c7xv_mems,
+ .num_mems = ARRAY_SIZE(c7xv_mems),
+ .boot_align_addr = SZ_2M,
+ .uses_lreset = false,
+};
+
static const struct of_device_id k3_dsp_of_match[] = {
{ .compatible = "ti,j721e-c66-dsp", .data = &c66_data, },
{ .compatible = "ti,j721e-c71-dsp", .data = &c71_data, },
{ .compatible = "ti,j721s2-c71-dsp", .data = &c71_data, },
+ { .compatible = "ti,am62a-c7xv-dsp", .data = &c7xv_data, },
{ /* sentinel */ },
};
MODULE_DEVICE_TABLE(of, k3_dsp_of_match);
--
2.17.1

2022-12-28 13:42:37

by Vignesh Raghavendra

Subject: Re: [PATCH 2/2] remoteproc: k3-c7x: Add support for C7xv DSP on AM62A SoC

Hi Hari,

On 12/28/2022 6:06 PM, Hari Nagalla wrote:
> Add support to the K3 DSP remoteproc driver to configure the C7xv
> subsystem core on AM62A SoCs. The C7xv susbsytem is based on C71 DSP
> with anlytics engine for deep leraning purposes. The remoteproc
> handling for device management is similar to the C66/C71 DSPs on K3
> J7 family SoCs, even though there are additional hardware accelerators
> and IP updates to C7xv subsystem.
>
> Signed-off-by: Hari Nagalla <[email protected]>
> Signed-off-by: Jai Luthra <[email protected]>
> ---

Signed-off-by of submitter should be at the last.

I see original author of the patch is Jai here. So you need to amend the
patch such that original author is set to Jai. His Signed-off-by should
be the first and then yours.

> drivers/remoteproc/ti_k3_dsp_remoteproc.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/remoteproc/ti_k3_dsp_remoteproc.c b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
> index eb9c64f7b9b4..ec626a37fef6 100644
> --- a/drivers/remoteproc/ti_k3_dsp_remoteproc.c
> +++ b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
> @@ -870,6 +870,10 @@ static const struct k3_dsp_mem_data c71_mems[] = {
> { .name = "l1dram", .dev_addr = 0xe00000 },
> };
>
> +static const struct k3_dsp_mem_data c7xv_mems[] = {
> + { .name = "l2sram", .dev_addr = 0x800000 },
> +};
> +
> static const struct k3_dsp_dev_data c66_data = {
> .mems = c66_mems,
> .num_mems = ARRAY_SIZE(c66_mems),
> @@ -884,10 +888,18 @@ static const struct k3_dsp_dev_data c71_data = {
> .uses_lreset = false,
> };
>
> +static const struct k3_dsp_dev_data c7xv_data = {
> + .mems = c7xv_mems,
> + .num_mems = ARRAY_SIZE(c7xv_mems),
> + .boot_align_addr = SZ_2M,
> + .uses_lreset = false,
> +};
> +
> static const struct of_device_id k3_dsp_of_match[] = {
> { .compatible = "ti,j721e-c66-dsp", .data = &c66_data, },
> { .compatible = "ti,j721e-c71-dsp", .data = &c71_data, },
> { .compatible = "ti,j721s2-c71-dsp", .data = &c71_data, },
> + { .compatible = "ti,am62a-c7xv-dsp", .data = &c7xv_data, },
> { /* sentinel */ },
> };
> MODULE_DEVICE_TABLE(of, k3_dsp_of_match);

2022-12-30 13:37:17

by Hari Nagalla

Subject: Re: [PATCH 2/2] remoteproc: k3-c7x: Add support for C7xv DSP on AM62A SoC

On 12/28/22 07:32, Raghavendra, Vignesh wrote:
>> with anlytics engine for deep leraning purposes. The remoteproc
>> handling for device management is similar to the C66/C71 DSPs on K3
>> J7 family SoCs, even though there are additional hardware accelerators
>> and IP updates to C7xv subsystem.
>>
>> Signed-off-by: Hari Nagalla<[email protected]>
>> Signed-off-by: Jai Luthra<[email protected]>
>> ---
> Signed-off-by of submitter should be at the last.
>
> I see original author of the patch is Jai here. So you need to amend the
> patch such that original author is set to Jai. His Signed-off-by should
> be the first and then yours.
>
Thanks for pointing it out. Fixed, sending v2 with the corrections.