2022-12-31 15:34:44

by Changbin Du

Subject: [PATCH] libbpf: Return -ENODATA for missing btf section

As discussed before, return -ENODATA (No data available) would be more
meaningful than ENOENT (No such file or directory).

Suggested-by: Leo Yan <[email protected]>
Cc: Andrii Nakryiko <[email protected]>
Signed-off-by: Changbin Du <[email protected]>
---
tools/lib/bpf/btf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/lib/bpf/btf.c b/tools/lib/bpf/btf.c
index dd2badf1a54e..2c89454c0136 100644
--- a/tools/lib/bpf/btf.c
+++ b/tools/lib/bpf/btf.c
@@ -991,7 +991,7 @@ static struct btf *btf_parse_elf(const char *path, struct btf *base_btf,

if (!btf_data) {
pr_warn("failed to find '%s' ELF section in %s\n", BTF_ELF_SEC, path);
- err = -ENOENT;
+ err = -ENODATA;
goto done;
}
btf = btf_new(btf_data->d_buf, btf_data->d_size, base_btf);
--
2.37.2

2023-01-03 22:51:57

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] libbpf: Return -ENODATA for missing btf section

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <[email protected]>:

On Sat, 31 Dec 2022 23:14:36 +0800 you wrote:
> As discussed before, return -ENODATA (No data available) would be more
> meaningful than ENOENT (No such file or directory).
>
> Suggested-by: Leo Yan <[email protected]>
> Cc: Andrii Nakryiko <[email protected]>
> Signed-off-by: Changbin Du <[email protected]>
>
> [...]

Here is the summary with links:
- libbpf: Return -ENODATA for missing btf section
https://git.kernel.org/bpf/bpf-next/c/acd3b7768048

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html