2023-01-06 08:51:40

by Pankaj Raghav

Subject: [PATCH 1/7] block: remove superfluous check for request queue in bdev_is_zoned

Remove the superfluous request queue check in bdev_is_zoned() as the
bdev_get_queue can never return NULL.

Signed-off-by: Pankaj Raghav <[email protected]>
---
include/linux/blkdev.h | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 43d4e073b111..0e40b014c40b 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1283,12 +1283,7 @@ static inline enum blk_zoned_model bdev_zoned_model(struct block_device *bdev)

static inline bool bdev_is_zoned(struct block_device *bdev)
{
- struct request_queue *q = bdev_get_queue(bdev);
-
- if (q)
- return blk_queue_is_zoned(q);
-
- return false;
+ return blk_queue_is_zoned(bdev_get_queue(bdev));
}

static inline bool bdev_op_is_zoned_write(struct block_device *bdev,
--
2.25.1

2023-01-06 11:27:35

by Damien Le Moal

Subject: Re: [PATCH 1/7] block: remove superfluous check for request queue in bdev_is_zoned

On 1/6/23 17:33, Pankaj Raghav wrote:
> Remove the superfluous request queue check in bdev_is_zoned() as the
> bdev_get_queue can never return NULL.
>
> Signed-off-by: Pankaj Raghav <[email protected]>
> ---
> include/linux/blkdev.h | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 43d4e073b111..0e40b014c40b 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -1283,12 +1283,7 @@ static inline enum blk_zoned_model bdev_zoned_model(struct block_device *bdev)
>
> static inline bool bdev_is_zoned(struct block_device *bdev)
> {
> - struct request_queue *q = bdev_get_queue(bdev);
> -
> - if (q)
> - return blk_queue_is_zoned(q);
> -
> - return false;
> + return blk_queue_is_zoned(bdev_get_queue(bdev));
> }
>
> static inline bool bdev_op_is_zoned_write(struct block_device *bdev,

Reviewed-by: Damien Le Moal <[email protected]>

--
Damien Le Moal
Western Digital Research

2023-01-06 22:45:37

by Bart Van Assche

Subject: Re: [PATCH 1/7] block: remove superfluous check for request queue in bdev_is_zoned

On 1/6/23 00:33, Pankaj Raghav wrote:
> Remove the superfluous request queue check in bdev_is_zoned() as the
> bdev_get_queue can never return NULL.

the bdev_get_queue -> bdev_get_queue()

Anyway:

Reviewed-by: Bart Van Assche <[email protected]>

2023-01-09 07:54:52

by Chaitanya Kulkarni

Subject: Re: [PATCH 1/7] block: remove superfluous check for request queue in bdev_is_zoned

On 1/6/23 00:33, Pankaj Raghav wrote:
> Remove the superfluous request queue check in bdev_is_zoned() as the
> bdev_get_queue can never return NULL.
>
> Signed-off-by: Pankaj Raghav <[email protected]>
> ---

Looks good.

Reviewed-by: Chaitanya Kulkarni <[email protected]>

-ck

2023-01-09 09:44:17

by Johannes Thumshirn

Subject: Re: [PATCH 1/7] block: remove superfluous check for request queue in bdev_is_zoned

On 06.01.23 09:34, Pankaj Raghav wrote:
> Remove the superfluous request queue check in bdev_is_zoned() as the

minus the last 'the'

Looks good,
Reviewed-by: Johannes Thumshirn <[email protected]>

2023-01-10 07:55:02

by Christoph Hellwig

Subject: Re: [PATCH 1/7] block: remove superfluous check for request queue in bdev_is_zoned

Looks good:

Reviewed-by: Christoph Hellwig <[email protected]>