2023-01-06 09:39:45

by Yu Zhe

Subject: [PATCH] io_uring: fix some spelling mistakes in comment

Fix typos in comment.

Signed-off-by: Yu Zhe <[email protected]>
---
io_uring/io_uring.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
index 58ac13b69dc8..99074d5fe195 100644
--- a/io_uring/io_uring.c
+++ b/io_uring/io_uring.c
@@ -557,7 +557,7 @@ static void io_eventfd_flush_signal(struct io_ring_ctx *ctx)
* Eventfd should only get triggered when at least one event has been
* posted. Some applications rely on the eventfd notification count
* only changing IFF a new CQE has been added to the CQ ring. There's
- * no depedency on 1:1 relationship between how many times this
+ * no dependency on 1:1 relationship between how many times this
* function is called (and hence the eventfd count) and number of CQEs
* posted to the CQ ring.
*/
@@ -2822,7 +2822,7 @@ static __cold void io_tctx_exit_cb(struct callback_head *cb)
* When @in_idle, we're in cancellation and it's racy to remove the
* node. It'll be removed by the end of cancellation, just ignore it.
* tctx can be NULL if the queueing of this task_work raced with
- * work cancelation off the exec path.
+ * work cancellation off the exec path.
*/
if (tctx && !atomic_read(&tctx->in_idle))
io_uring_del_tctx_node((unsigned long)work->ctx);
@@ -3095,7 +3095,7 @@ __cold void io_uring_cancel_generic(bool cancel_all, struct io_sq_data *sqd)
bool loop = false;

io_uring_drop_tctx_refs(current);
- /* read completions before cancelations */
+ /* read completions before cancellations */
inflight = tctx_inflight(tctx, !cancel_all);
if (!inflight)
break;
--
2.11.0

2023-01-06 09:43:45

by Ammar Faizi

Subject: Re: [PATCH] io_uring: fix some spelling mistakes in comment

On Fri, Jan 06, 2023 at 05:12:42PM +0800, Yu Zhe wrote:
> @@ -2822,7 +2822,7 @@ static __cold void io_tctx_exit_cb(struct callback_head *cb)
> * When @in_idle, we're in cancellation and it's racy to remove the
> * node. It'll be removed by the end of cancellation, just ignore it.
> * tctx can be NULL if the queueing of this task_work raced with
> - * work cancelation off the exec path.
> + * work cancellation off the exec path.
> */
> if (tctx && !atomic_read(&tctx->in_idle))
> io_uring_del_tctx_node((unsigned long)work->ctx);
> @@ -3095,7 +3095,7 @@ __cold void io_uring_cancel_generic(bool cancel_all, struct io_sq_data *sqd)
> bool loop = false;
>
> io_uring_drop_tctx_refs(current);
> - /* read completions before cancelations */
> + /* read completions before cancellations */

"cancelations" is not a typo.

"cancelations" and "cancellations" are both valid spellings. The former
is predominantly used in the US, while the latter is predominantly used
in the UK.

--
Ammar Faizi

2023-01-06 09:59:29

by Dan Carpenter

Subject: Re: [PATCH] io_uring: fix some spelling mistakes in comment

On Fri, Jan 06, 2023 at 05:12:42PM +0800, Yu Zhe wrote:
> Fix typos in comment.
>

The cancelation vs cancellation thing is a British vs American spelling
difference. (Leave it as-is).

regards,
dan carpenter