2023-01-06 17:51:38

by SeongJae Park

Subject: [PATCH 3/3] fs/ceph/addr: use folio_headpage() instead of folio_page()

Using 'folio_page(folio, 0)' for getting the head page of a folios is
not the standard idiom and inefficient. Replace the call in fs/ceph/ to
'folio_headpage()'.

Signed-off-by: SeongJae Park <[email protected]>
---
fs/ceph/addr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
index 8c74871e37c9..b76e94152b21 100644
--- a/fs/ceph/addr.c
+++ b/fs/ceph/addr.c
@@ -1290,7 +1290,7 @@ static int ceph_netfs_check_write_begin(struct file *file, loff_t pos, unsigned
struct ceph_inode_info *ci = ceph_inode(inode);
struct ceph_snap_context *snapc;

- snapc = ceph_find_incompatible(folio_page(*foliop, 0));
+ snapc = ceph_find_incompatible(folio_headpage(*foliop));
if (snapc) {
int r;

--
2.25.1

2023-01-06 20:13:20

by Matthew Wilcox

Subject: Re: [PATCH 3/3] fs/ceph/addr: use folio_headpage() instead of folio_page()

On Fri, Jan 06, 2023 at 05:40:28PM +0000, SeongJae Park wrote:
> - snapc = ceph_find_incompatible(folio_page(*foliop, 0));
> + snapc = ceph_find_incompatible(folio_headpage(*foliop));

ceph_find_incompatible() should take a folio.