Subject: [PATCH 14/15] backlight: tosa: Use backlight helper

From: Stephen Kitt <[email protected]>

Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.

Signed-off-by: Stephen Kitt <[email protected]>
Signed-off-by: Sam Ravnborg <[email protected]>
---
drivers/video/backlight/tosa_bl.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/video/backlight/tosa_bl.c b/drivers/video/backlight/tosa_bl.c
index f55b3d616a87..cb07f13dd886 100644
--- a/drivers/video/backlight/tosa_bl.c
+++ b/drivers/video/backlight/tosa_bl.c
@@ -50,13 +50,8 @@ static void tosa_bl_set_backlight(struct tosa_bl_data *data, int brightness)

static int tosa_bl_update_status(struct backlight_device *dev)
{
- struct backlight_properties *props = &dev->props;
struct tosa_bl_data *data = bl_get_data(dev);
- int power = max(props->power, props->fb_blank);
- int brightness = props->brightness;
-
- if (power)
- brightness = 0;
+ int brightness = backlight_get_brightness(dev);

tosa_bl_set_backlight(data, brightness);


--
2.34.1


2023-01-09 11:36:36

by Daniel Thompson

[permalink] [raw]
Subject: Re: [PATCH 14/15] backlight: tosa: Use backlight helper

On Sat, Jan 07, 2023 at 07:26:28PM +0100, Sam Ravnborg via B4 Submission Endpoint wrote:
> From: Stephen Kitt <[email protected]>
>
> Instead of retrieving the backlight brightness in struct
> backlight_properties manually, and then checking whether the backlight
> should be on at all, use backlight_get_brightness() which does all
> this and insulates this from future changes.
>
> Signed-off-by: Stephen Kitt <[email protected]>
> Signed-off-by: Sam Ravnborg <[email protected]>

Just for completeness...
Reviewed-by: Daniel Thompson <[email protected]>


Daniel.