2023-01-09 19:12:17

by Dmitrii Bundin

Subject: [PATCH] io_uring: remove excessive unlikely on IS_ERR

The IS_ERR function uses the IS_ERR_VALUE macro under the hood which
already wraps the condition into unlikely.

Signed-off-by: Dmitrii Bundin <[email protected]>
---
io_uring/rw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/io_uring/rw.c b/io_uring/rw.c
index 8227af2e1c0f..27d5e3323a53 100644
--- a/io_uring/rw.c
+++ b/io_uring/rw.c
@@ -410,7 +410,7 @@ static inline int io_import_iovec(int rw, struct io_kiocb *req,
unsigned int issue_flags)
{
*iovec = __io_import_iovec(rw, req, s, issue_flags);
- if (unlikely(IS_ERR(*iovec)))
+ if (IS_ERR(*iovec))
return PTR_ERR(*iovec);

iov_iter_save_state(&s->iter, &s->iter_state);
--
2.17.1

2023-01-09 23:39:30

by Jens Axboe

Subject: Re: [PATCH] io_uring: remove excessive unlikely on IS_ERR

On Mon, 09 Jan 2023 21:58:54 +0300, Dmitrii Bundin wrote:
> The IS_ERR function uses the IS_ERR_VALUE macro under the hood which
> already wraps the condition into unlikely.
>
>

Applied, thanks!

[1/1] io_uring: remove excessive unlikely on IS_ERR
commit: 119fda37c54736ea65a669273d0b3c394c99a75c

Best regards,
--
Jens Axboe