2023-01-11 09:38:10

by Lv qian

Subject: [PATCH V2] mm/slab.c: Delete the if statement

From: lvqian <[email protected]>

Remove the if statement to increase code readability.

Signed-off-by: lvqian <[email protected]>
---
v2: Modify the subject content
---
mm/slab.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/mm/slab.c b/mm/slab.c
index 7a269db050ee..713265fe2dea 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -1415,11 +1415,8 @@ static void kmem_rcu_free(struct rcu_head *head)
#if DEBUG
static bool is_debug_pagealloc_cache(struct kmem_cache *cachep)
{
- if (debug_pagealloc_enabled_static() && OFF_SLAB(cachep) &&
- (cachep->size % PAGE_SIZE) == 0)
- return true;
-
- return false;
+ return debug_pagealloc_enabled_static() && OFF_SLAB(cachep) &&
+ ((cachep->size % PAGE_SIZE) == 0);
}

#ifdef CONFIG_DEBUG_PAGEALLOC
--
2.34.1

2023-01-13 00:12:56

by David Rientjes

Subject: Re: [PATCH V2] mm/slab.c: Delete the if statement

On Wed, 11 Jan 2023, [email protected] wrote:

> From: lvqian <[email protected]>
>
> Remove the if statement to increase code readability.
>
> Signed-off-by: lvqian <[email protected]>

Acked-by: David Rientjes <[email protected]>

Will rely on Vlastimil to remove the spurious tab in the commit
description. Function could be inline, but no strong preference.

2023-01-13 11:52:13

by Vlastimil Babka

Subject: Re: [PATCH V2] mm/slab.c: Delete the if statement

On 1/13/23 00:53, David Rientjes wrote:
> On Wed, 11 Jan 2023, [email protected] wrote:
>
>> From: lvqian <[email protected]>
>>
>> Remove the if statement to increase code readability.
>>
>> Signed-off-by: lvqian <[email protected]>
>
> Acked-by: David Rientjes <[email protected]>
>
> Will rely on Vlastimil to remove the spurious tab in the commit
> description.

Right, also changed subject to:
mm/slab.c: cleanup is_debug_pagealloc_cache()

Function could be inline, but no strong preference.

Good point, did that too.

Added to
slab/for-6.3/cleanups

Thanks.