Hi all,
After merging the workqueues tree, today's linux-next build (x86_64
allnoconfig and several others) produced this warning:
kernel/workqueue.c:1993:13: warning: 'rebind_worker' defined but not used [-Wunused-function]
1993 | static void rebind_worker(struct worker *worker, struct worker_pool *pool)
| ^~~~~~~~~~~~~
Introduced by commit
793777bc193b ("workqueue: Factorize unbind/rebind_workers() logic")
--
Cheers,
Stephen Rothwell
On 13/01/23 06:31, Tejun Heo wrote:
> On Fri, Jan 13, 2023 at 02:31:02PM +1100, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the workqueues tree, today's linux-next build (x86_64
>> allnoconfig and several others) produced this warning:
>>
>> kernel/workqueue.c:1993:13: warning: 'rebind_worker' defined but not used [-Wunused-function]
>> 1993 | static void rebind_worker(struct worker *worker, struct worker_pool *pool)
>> | ^~~~~~~~~~~~~
>>
>> Introduced by commit
>>
>> 793777bc193b ("workqueue: Factorize unbind/rebind_workers() logic")
>
> Valentin, this is caused by rebind_worker() being only used by
> rebind_workers() which is inside CONFIG_SMP. I don't see any other uses of
> rebind_worker(). Just fold it back into rebind_workers()?
>
Woops! Yes I only did it to keep things aligned with unbind_workers(), let
me resend with that folded back in. Sorry!
> Thanks.
>
> --
> tejun
On 13/01/23 16:47, Valentin Schneider wrote:
> On 13/01/23 06:31, Tejun Heo wrote:
>> On Fri, Jan 13, 2023 at 02:31:02PM +1100, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> After merging the workqueues tree, today's linux-next build (x86_64
>>> allnoconfig and several others) produced this warning:
>>>
>>> kernel/workqueue.c:1993:13: warning: 'rebind_worker' defined but not used [-Wunused-function]
>>> 1993 | static void rebind_worker(struct worker *worker, struct worker_pool *pool)
>>> | ^~~~~~~~~~~~~
>>>
>>> Introduced by commit
>>>
>>> 793777bc193b ("workqueue: Factorize unbind/rebind_workers() logic")
>>
>> Valentin, this is caused by rebind_worker() being only used by
>> rebind_workers() which is inside CONFIG_SMP. I don't see any other uses of
>> rebind_worker(). Just fold it back into rebind_workers()?
>>
>
> Woops! Yes I only did it to keep things aligned with unbind_workers(), let
> me resend with that folded back in. Sorry!
>
Unless you'd prefer a fixup patch on top of those you've already picked up?
>> Thanks.
>>
>> --
>> tejun
On Fri, Jan 13, 2023 at 02:31:02PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the workqueues tree, today's linux-next build (x86_64
> allnoconfig and several others) produced this warning:
>
> kernel/workqueue.c:1993:13: warning: 'rebind_worker' defined but not used [-Wunused-function]
> 1993 | static void rebind_worker(struct worker *worker, struct worker_pool *pool)
> | ^~~~~~~~~~~~~
>
> Introduced by commit
>
> 793777bc193b ("workqueue: Factorize unbind/rebind_workers() logic")
Valentin, this is caused by rebind_worker() being only used by
rebind_workers() which is inside CONFIG_SMP. I don't see any other uses of
rebind_worker(). Just fold it back into rebind_workers()?
Thanks.
--
tejun
On Fri, Jan 13, 2023 at 04:48:29PM +0000, Valentin Schneider wrote:
> On 13/01/23 16:47, Valentin Schneider wrote:
> > On 13/01/23 06:31, Tejun Heo wrote:
> >> On Fri, Jan 13, 2023 at 02:31:02PM +1100, Stephen Rothwell wrote:
> >>> Hi all,
> >>>
> >>> After merging the workqueues tree, today's linux-next build (x86_64
> >>> allnoconfig and several others) produced this warning:
> >>>
> >>> kernel/workqueue.c:1993:13: warning: 'rebind_worker' defined but not used [-Wunused-function]
> >>> 1993 | static void rebind_worker(struct worker *worker, struct worker_pool *pool)
> >>> | ^~~~~~~~~~~~~
> >>>
> >>> Introduced by commit
> >>>
> >>> 793777bc193b ("workqueue: Factorize unbind/rebind_workers() logic")
> >>
> >> Valentin, this is caused by rebind_worker() being only used by
> >> rebind_workers() which is inside CONFIG_SMP. I don't see any other uses of
> >> rebind_worker(). Just fold it back into rebind_workers()?
> >>
> >
> > Woops! Yes I only did it to keep things aligned with unbind_workers(), let
> > me resend with that folded back in. Sorry!
> >
>
> Unless you'd prefer a fixup patch on top of those you've already picked up?
Yeah, just send another patch to fold it back in.
Thanks.
--
tejun