2023-01-20 02:16:44

by Rob Herring (Arm)

Subject: [PATCH] dt-bindings: pinctrl: qcom,pmic-mpp: Restrict 'mpp' child node name pattern

Just 'mpp' is a bit ambiguous for a pattern. It allows any prefix or
suffix. I couldn't find any actual users, so update the pattern to match
the example.

Signed-off-by: Rob Herring <[email protected]>
---
Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
index 72cce38bc1ce..891a7385d7cb 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
@@ -74,7 +74,7 @@ patternProperties:
oneOf:
- $ref: "#/$defs/qcom-pmic-mpp-state"
- patternProperties:
- "mpp":
+ "-mpp$":
$ref: "#/$defs/qcom-pmic-mpp-state"
additionalProperties: false

--
2.39.0

2023-01-20 04:33:20

by Bjorn Andersson

Subject: Re: [PATCH] dt-bindings: pinctrl: qcom,pmic-mpp: Restrict 'mpp' child node name pattern

On Thu, Jan 19, 2023 at 08:06:00PM -0600, Rob Herring wrote:
> Just 'mpp' is a bit ambiguous for a pattern. It allows any prefix or
> suffix. I couldn't find any actual users, so update the pattern to match
> the example.
>
> Signed-off-by: Rob Herring <[email protected]>
> ---
> Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
> index 72cce38bc1ce..891a7385d7cb 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
> @@ -74,7 +74,7 @@ patternProperties:
> oneOf:
> - $ref: "#/$defs/qcom-pmic-mpp-state"
> - patternProperties:
> - "mpp":
> + "-mpp$":

How about aligning it with the other Qualcomm pinctrl bindings and make
it "-pins$" instead?

If my grep is correct we have one "mpp5" and two "-pins$" currently in
the sources, so this should be beneficial as well.

Regards,
Bjorn

> $ref: "#/$defs/qcom-pmic-mpp-state"
> additionalProperties: false
>
> --
> 2.39.0
>

2023-01-20 06:59:09

by Krzysztof Kozlowski

Subject: Re: [PATCH] dt-bindings: pinctrl: qcom,pmic-mpp: Restrict 'mpp' child node name pattern

On 20/01/2023 05:29, Bjorn Andersson wrote:
> On Thu, Jan 19, 2023 at 08:06:00PM -0600, Rob Herring wrote:
>> Just 'mpp' is a bit ambiguous for a pattern. It allows any prefix or
>> suffix. I couldn't find any actual users, so update the pattern to match
>> the example.
>>
>> Signed-off-by: Rob Herring <[email protected]>
>> ---
>> Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
>> index 72cce38bc1ce..891a7385d7cb 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
>> @@ -74,7 +74,7 @@ patternProperties:
>> oneOf:
>> - $ref: "#/$defs/qcom-pmic-mpp-state"
>> - patternProperties:
>> - "mpp":
>> + "-mpp$":
>
> How about aligning it with the other Qualcomm pinctrl bindings and make
> it "-pins$" instead?
>
> If my grep is correct we have one "mpp5" and two "-pins$" currently in
> the sources, so this should be beneficial as well.

Let's align it with other Qualcomm pinctrl bindings, so:
"-pins$":

I can also fix the DTS to match it.

Best regards,
Krzysztof