Hi all,
After merging the tty.current tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/tty/serial/stm32-usart.c: In function 'stm32_usart_interrupt':
drivers/tty/serial/stm32-usart.c:804:62: error: 'flags' undeclared (first use in this function)
804 | uart_unlock_and_check_sysrq_irqrestore(port, flags);
| ^~~~~
drivers/tty/serial/stm32-usart.c:804:62: note: each undeclared identifier is reported only once for each function it appears in
Caused by commit
f24771b62a83 ("serial: stm32: Merge hard IRQ and threaded IRQ handling into single IRQ handler")
I have used the tty.current tree from next-20230119 for today.
--
Cheers,
Stephen Rothwell
On 1/19/23 21:58, Stephen Rothwell wrote:
> Hi all,
Hi,
> After merging the tty.current tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/tty/serial/stm32-usart.c: In function 'stm32_usart_interrupt':
> drivers/tty/serial/stm32-usart.c:804:62: error: 'flags' undeclared (first use in this function)
> 804 | uart_unlock_and_check_sysrq_irqrestore(port, flags);
> | ^~~~~
> drivers/tty/serial/stm32-usart.c:804:62: note: each undeclared identifier is reported only once for each function it appears in
>
> Caused by commit
>
> f24771b62a83 ("serial: stm32: Merge hard IRQ and threaded IRQ handling into single IRQ handler")
>
> I have used the tty.current tree from next-20230119 for today.
I already proposed a fix in the build robot report
[tty:tty-linus 4/7] drivers/tty/serial/stm32-usart.c:804:62: error:
'flags' undeclared
Now waiting for Johan to confirm that's the correct approach.
On Fri, Jan 20, 2023 at 07:58:32AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the tty.current tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/tty/serial/stm32-usart.c: In function 'stm32_usart_interrupt':
> drivers/tty/serial/stm32-usart.c:804:62: error: 'flags' undeclared (first use in this function)
> 804 | uart_unlock_and_check_sysrq_irqrestore(port, flags);
> | ^~~~~
> drivers/tty/serial/stm32-usart.c:804:62: note: each undeclared identifier is reported only once for each function it appears in
>
> Caused by commit
>
> f24771b62a83 ("serial: stm32: Merge hard IRQ and threaded IRQ handling into single IRQ handler")
>
> I have used the tty.current tree from next-20230119 for today.
Should now be fixed up as I reverted this, thanks!
greg k-h