2023-01-20 18:58:48

by Krzysztof Kozlowski

Subject: [PATCH] ARM: dts: qcom: apq8060-dragonboard: align MPP pin node names with DT schema

DT schema expects nodes ending with "pins:

qcom-apq8060-dragonboard.dtb: mpps@50: cm3605-mpps-state: 'oneOf' conditional failed, one must be fixed:
'mpp5' does not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Warning visible after:
https://lore.kernel.org/r/[email protected]
---
arch/arm/boot/dts/qcom-apq8060-dragonboard.dts | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
index 7a4c59e04af6..8e4b61e4d4b1 100644
--- a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
+++ b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
@@ -435,15 +435,13 @@ &pm8058_led133 {

&pm8058_mpps {
dragon_cm3605_mpps: cm3605-mpps-state {
- mpp5 {
- pins = "mpp5";
- function = "analog";
- input-enable;
- bias-high-impedance;
- /* Let's use channel 5 */
- qcom,amux-route = <PMIC_MPP_AMUX_ROUTE_CH5>;
- power-source = <PM8058_GPIO_S3>;
- };
+ pins = "mpp5";
+ function = "analog";
+ input-enable;
+ bias-high-impedance;
+ /* Let's use channel 5 */
+ qcom,amux-route = <PMIC_MPP_AMUX_ROUTE_CH5>;
+ power-source = <PM8058_GPIO_S3>;
};
};

--
2.34.1

2023-01-20 20:07:36

by Konrad Dybcio

Subject: Re: [PATCH] ARM: dts: qcom: apq8060-dragonboard: align MPP pin node names with DT schema

On 20.01.2023 18:40, Krzysztof Kozlowski wrote:
> DT schema expects nodes ending with "pins:
>
> qcom-apq8060-dragonboard.dtb: mpps@50: cm3605-mpps-state: 'oneOf' conditional failed, one must be fixed:
> 'mpp5' does not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
>
> Warning visible after:
> https://lore.kernel.org/r/[email protected]
> ---
> arch/arm/boot/dts/qcom-apq8060-dragonboard.dts | 16 +++++++---------
> 1 file changed, 7 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> index 7a4c59e04af6..8e4b61e4d4b1 100644
> --- a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> +++ b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> @@ -435,15 +435,13 @@ &pm8058_led133 {
>
> &pm8058_mpps {
> dragon_cm3605_mpps: cm3605-mpps-state {
> - mpp5 {
> - pins = "mpp5";
> - function = "analog";
> - input-enable;
> - bias-high-impedance;
> - /* Let's use channel 5 */
> - qcom,amux-route = <PMIC_MPP_AMUX_ROUTE_CH5>;
> - power-source = <PM8058_GPIO_S3>;
> - };
> + pins = "mpp5";
> + function = "analog";
> + input-enable;
> + bias-high-impedance;
> + /* Let's use channel 5 */
> + qcom,amux-route = <PMIC_MPP_AMUX_ROUTE_CH5>;
> + power-source = <PM8058_GPIO_S3>;
> };
> };
>

2023-02-09 04:33:12

by Bjorn Andersson

Subject: Re: [PATCH] ARM: dts: qcom: apq8060-dragonboard: align MPP pin node names with DT schema

On Fri, 20 Jan 2023 18:40:36 +0100, Krzysztof Kozlowski wrote:
> DT schema expects nodes ending with "pins:
>
> qcom-apq8060-dragonboard.dtb: mpps@50: cm3605-mpps-state: 'oneOf' conditional failed, one must be fixed:
> 'mpp5' does not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
>
>

Applied, thanks!

[1/1] ARM: dts: qcom: apq8060-dragonboard: align MPP pin node names with DT schema
commit: e58065542e8e95351df86dd3b5ef45dd05c2aa47

Best regards,
--
Bjorn Andersson <[email protected]>