Some of the pinctrl groups were invalid for the selected pins. Select
the proper qup group to fix these warnings:
[ 6.523566] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio135" for function "qup15"
[ 6.535042] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio136" for function "qup15"
[ 6.597536] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio158" for function "qup15"
[ 6.597544] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio159" for function "qup15"
[ 6.597991] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio0" for function "qup15"
[ 6.597996] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio1" for function "qup15"
Fixes: e073899ec3e1 ("arm64: dts: qcom: sa8540p-ride: add i2c nodes")
Reviewed-by: Shazad Hussain <[email protected]>
Reviewed-by: Konrad Dybcio <[email protected]>
Reviewed-by: Brian Masney <[email protected]>
Signed-off-by: Andrew Halaney <[email protected]>
---
Changes since v1:
* collected Reviewed-by tags
arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
index a43f831f9018..6ab4b435c49e 100644
--- a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
+++ b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
@@ -318,21 +318,21 @@ &xo_board_clk {
&tlmm {
i2c0_default: i2c0-default-state {
pins = "gpio135", "gpio136";
- function = "qup15";
+ function = "qup0";
drive-strength = <2>;
bias-pull-up;
};
i2c1_default: i2c1-default-state {
pins = "gpio158", "gpio159";
- function = "qup15";
+ function = "qup1";
drive-strength = <2>;
bias-pull-up;
};
i2c12_default: i2c12-default-state {
pins = "gpio0", "gpio1";
- function = "qup15";
+ function = "qup12";
drive-strength = <2>;
bias-pull-up;
};
--
2.39.1
It isn't obvious in the current devicetree what is connected. Go ahead
and document what's on the other end.
Signed-off-by: Andrew Halaney <[email protected]>
---
Changes since v1:
* Document i2c12 having a max20411 (Shazad)
In v1 I said i2c12 was not connected, that's not true though (I just
have a board schematic which shows it not connected, but it _is_
connected on the SIP/SOM, which I verified with series [0]).
I debated waiting for Bjorn to sort out appropriate label names over at
[0] (and follow suit in a third patch here), but decided to get this
series out again to clean up the current warnings while that's worked
out. Once [0] is resubmitted I'll submit a separate patch to enable the
max20411 on this board as well!
[0] https://lore.kernel.org/linux-arm-msm/[email protected]/
Thanks,
Andrew
arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
index 6ab4b435c49e..8b7555f22528 100644
--- a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
+++ b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
@@ -317,6 +317,7 @@ &xo_board_clk {
&tlmm {
i2c0_default: i2c0-default-state {
+ /* To USB7002T-I/KDXVA0 USB hub (SIP1 only) */
pins = "gpio135", "gpio136";
function = "qup0";
drive-strength = <2>;
@@ -324,6 +325,7 @@ i2c0_default: i2c0-default-state {
};
i2c1_default: i2c1-default-state {
+ /* To PM40028B-F3EI PCIe switch */
pins = "gpio158", "gpio159";
function = "qup1";
drive-strength = <2>;
@@ -331,6 +333,7 @@ i2c1_default: i2c1-default-state {
};
i2c12_default: i2c12-default-state {
+ /* To Maxim max20411 */
pins = "gpio0", "gpio1";
function = "qup12";
drive-strength = <2>;
@@ -338,6 +341,7 @@ i2c12_default: i2c12-default-state {
};
i2c15_default: i2c15-default-state {
+ /* To display connector (SIP1 only) */
pins = "gpio36", "gpio37";
function = "qup15";
drive-strength = <2>;
@@ -345,6 +349,7 @@ i2c15_default: i2c15-default-state {
};
i2c18_default: i2c18-default-state {
+ /* To ASM330LHH IMU (SIP1 only) */
pins = "gpio66", "gpio67";
function = "qup18";
drive-strength = <2>;
--
2.39.1
On Mon, Jan 30, 2023 at 09:48:23AM -0600, Andrew Halaney wrote:
> It isn't obvious in the current devicetree what is connected. Go ahead
> and document what's on the other end.
>
> Signed-off-by: Andrew Halaney <[email protected]>
> ---
Reviewed-by: Eric Chanudet <[email protected]>
>
> Changes since v1:
> * Document i2c12 having a max20411 (Shazad)
>
> In v1 I said i2c12 was not connected, that's not true though (I just
> have a board schematic which shows it not connected, but it _is_
> connected on the SIP/SOM, which I verified with series [0]).
>
> I debated waiting for Bjorn to sort out appropriate label names over at
> [0] (and follow suit in a third patch here), but decided to get this
> series out again to clean up the current warnings while that's worked
> out. Once [0] is resubmitted I'll submit a separate patch to enable the
> max20411 on this board as well!
>
> [0] https://lore.kernel.org/linux-arm-msm/[email protected]/
>
> Thanks,
> Andrew
>
> arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
> index 6ab4b435c49e..8b7555f22528 100644
> --- a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
> @@ -317,6 +317,7 @@ &xo_board_clk {
>
> &tlmm {
> i2c0_default: i2c0-default-state {
> + /* To USB7002T-I/KDXVA0 USB hub (SIP1 only) */
> pins = "gpio135", "gpio136";
> function = "qup0";
> drive-strength = <2>;
> @@ -324,6 +325,7 @@ i2c0_default: i2c0-default-state {
> };
>
> i2c1_default: i2c1-default-state {
> + /* To PM40028B-F3EI PCIe switch */
> pins = "gpio158", "gpio159";
> function = "qup1";
> drive-strength = <2>;
> @@ -331,6 +333,7 @@ i2c1_default: i2c1-default-state {
> };
>
> i2c12_default: i2c12-default-state {
> + /* To Maxim max20411 */
> pins = "gpio0", "gpio1";
> function = "qup12";
> drive-strength = <2>;
> @@ -338,6 +341,7 @@ i2c12_default: i2c12-default-state {
> };
>
> i2c15_default: i2c15-default-state {
> + /* To display connector (SIP1 only) */
> pins = "gpio36", "gpio37";
> function = "qup15";
> drive-strength = <2>;
> @@ -345,6 +349,7 @@ i2c15_default: i2c15-default-state {
> };
>
> i2c18_default: i2c18-default-state {
> + /* To ASM330LHH IMU (SIP1 only) */
> pins = "gpio66", "gpio67";
> function = "qup18";
> drive-strength = <2>;
> --
> 2.39.1
>
--
Eric Chanudet
On Mon, 30 Jan 2023 09:48:22 -0600, Andrew Halaney wrote:
> Some of the pinctrl groups were invalid for the selected pins. Select
> the proper qup group to fix these warnings:
>
> [ 6.523566] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio135" for function "qup15"
> [ 6.535042] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio136" for function "qup15"
> [ 6.597536] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio158" for function "qup15"
> [ 6.597544] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio159" for function "qup15"
> [ 6.597991] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio0" for function "qup15"
> [ 6.597996] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio1" for function "qup15"
>
> [...]
Applied, thanks!
[1/2] arm64: dts: qcom: sa8540p-ride: Fix some i2c pinctrl settings
commit: f187e989305a2d57dc0f750ebb63959151b66924
[2/2] arm64: dts: qcom: sa8540p-ride: Document i2c busses
commit: f1d6f9d227a0fe887d6a5cc7773425b267e4deff
Best regards,
--
Bjorn Andersson <[email protected]>