2023-02-02 09:05:12

by Tiezhu Yang

Subject: [PATCH] MIPS: Remove CONFIG_MIPS check in Makefile

CONFIG_MIPS is set as y by default in Kconfig, no need to check
it in Makefile.

Signed-off-by: Tiezhu Yang <[email protected]>
---
arch/mips/Makefile | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index 490dea0..6ed41c8b 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -316,11 +316,9 @@ KBUILD_CFLAGS += -fno-asynchronous-unwind-tables

KBUILD_LDFLAGS += -m $(ld-emul)

-ifdef CONFIG_MIPS
CHECKFLAGS += $(shell $(CC) $(KBUILD_CFLAGS) -dM -E -x c /dev/null | \
grep -E -vw '__GNUC_(MINOR_|PATCHLEVEL_)?_' | \
sed -e "s/^\#define /-D'/" -e "s/ /'='/" -e "s/$$/'/" -e 's/\$$/&&/g')
-endif

OBJCOPYFLAGS += --remove-section=.reginfo

--
2.1.0

2023-02-04 14:57:08

by Alexander Lobakin

Subject: Re: [PATCH] MIPS: Remove CONFIG_MIPS check in Makefile

From: Tiezhu Yang <[email protected]>
Date: Thu, 2 Feb 2023 17:05:02 +0800

> CONFIG_MIPS is set as y by default in Kconfig, no need to check
> it in Makefile.
>
> Signed-off-by: Tiezhu Yang <[email protected]>
> ---
> arch/mips/Makefile | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index 490dea0..6ed41c8b 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -316,11 +316,9 @@ KBUILD_CFLAGS += -fno-asynchronous-unwind-tables
>
> KBUILD_LDFLAGS += -m $(ld-emul)
>
> -ifdef CONFIG_MIPS
> CHECKFLAGS += $(shell $(CC) $(KBUILD_CFLAGS) -dM -E -x c /dev/null | \
> grep -E -vw '__GNUC_(MINOR_|PATCHLEVEL_)?_' | \
> sed -e "s/^\#define /-D'/" -e "s/ /'='/" -e "s/$$/'/" -e 's/\$$/&&/g')
> -endif

When you run `make clean/mrproper/distclean`, .config is not read. Thus,
this block may actually provoke errors when cleaning, that's why it's
guarded.
At least it was like that a couple years ago, can't say for sure if
these guards are needed, but better recheck.

>
> OBJCOPYFLAGS += --remove-section=.reginfo
>
> --
> 2.1.0

Thanks,
Olek