2023-02-10 02:43:59

by Jiapeng Chong

Subject: [PATCH] drm/amd/display: Remove the unused variable pre_connection_type

Variable pre_connection_type is not effectively used, so delete it.

Reported-by: Abaci Robot <[email protected]>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4031
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/gpu/drm/amd/display/dc/link/link_detection.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/link/link_detection.c b/drivers/gpu/drm/amd/display/dc/link/link_detection.c
index 63e75c392031..d224a44c4cc8 100644
--- a/drivers/gpu/drm/amd/display/dc/link/link_detection.c
+++ b/drivers/gpu/drm/amd/display/dc/link/link_detection.c
@@ -886,7 +886,6 @@ static bool detect_link_and_local_sink(struct dc_link *link,
struct dc_sink *prev_sink = NULL;
struct dpcd_caps prev_dpcd_caps;
enum dc_connection_type new_connection_type = dc_connection_none;
- enum dc_connection_type pre_connection_type = dc_connection_none;
const uint32_t post_oui_delay = 30; // 30ms

DC_LOGGER_INIT(link->ctx->logger);
@@ -923,7 +922,6 @@ static bool detect_link_and_local_sink(struct dc_link *link,

link_disconnect_sink(link);
if (new_connection_type != dc_connection_none) {
- pre_connection_type = link->type;
link->type = new_connection_type;
link->link_state_valid = false;

--
2.20.1.7.g153144c

2023-02-13 16:16:36

by Alex Deucher

Subject: Re: [PATCH] drm/amd/display: Remove the unused variable pre_connection_type

Applied. Thanks!

On Thu, Feb 9, 2023 at 9:44 PM Jiapeng Chong
<[email protected]> wrote:
>
> Variable pre_connection_type is not effectively used, so delete it.
>
> Reported-by: Abaci Robot <[email protected]>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4031
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> drivers/gpu/drm/amd/display/dc/link/link_detection.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/link/link_detection.c b/drivers/gpu/drm/amd/display/dc/link/link_detection.c
> index 63e75c392031..d224a44c4cc8 100644
> --- a/drivers/gpu/drm/amd/display/dc/link/link_detection.c
> +++ b/drivers/gpu/drm/amd/display/dc/link/link_detection.c
> @@ -886,7 +886,6 @@ static bool detect_link_and_local_sink(struct dc_link *link,
> struct dc_sink *prev_sink = NULL;
> struct dpcd_caps prev_dpcd_caps;
> enum dc_connection_type new_connection_type = dc_connection_none;
> - enum dc_connection_type pre_connection_type = dc_connection_none;
> const uint32_t post_oui_delay = 30; // 30ms
>
> DC_LOGGER_INIT(link->ctx->logger);
> @@ -923,7 +922,6 @@ static bool detect_link_and_local_sink(struct dc_link *link,
>
> link_disconnect_sink(link);
> if (new_connection_type != dc_connection_none) {
> - pre_connection_type = link->type;
> link->type = new_connection_type;
> link->link_state_valid = false;
>
> --
> 2.20.1.7.g153144c
>