2023-02-13 21:31:59

by Andrew Halaney

Subject: [PATCH 1/2] dt-bindings: net: snps,dwmac: Fix snps,reset-delays-us dependency

The schema had snps,reset-delay-us as dependent on snps,reset-gpio. The
actual property is called snps,reset-delays-us, so fix this to catch any
devicetree defining snsps,reset-delays-us without snps,reset-gpio.

Fixes: 7db3545aef5f ("dt-bindings: net: stmmac: Convert the binding to a schemas")
Signed-off-by: Andrew Halaney <[email protected]>
---
Documentation/devicetree/bindings/net/snps,dwmac.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index e88a86623fce..16b7d2904696 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
@@ -552,7 +552,7 @@ required:

dependencies:
snps,reset-active-low: ["snps,reset-gpio"]
- snps,reset-delay-us: ["snps,reset-gpio"]
+ snps,reset-delays-us: ["snps,reset-gpio"]

allOf:
- $ref: "ethernet-controller.yaml#"
--
2.39.1

2023-02-13 21:32:09

by Andrew Halaney

Subject: [PATCH 2/2] arm64: dts: imx8dxl-evk: Fix eqos phy reset gpio

The property is named snps,reset-gpio. Update the name accordingly so
the corresponding phy is reset.

Fixes: 8dd495d12374 ("arm64: dts: freescale: add support for i.MX8DXL EVK board")
Signed-off-by: Andrew Halaney <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
index 1bcf228a22b8..b6d7c2526131 100644
--- a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
@@ -121,7 +121,7 @@ &eqos {
phy-handle = <&ethphy0>;
nvmem-cells = <&fec_mac1>;
nvmem-cell-names = "mac-address";
- snps,reset-gpios = <&pca6416_1 2 GPIO_ACTIVE_LOW>;
+ snps,reset-gpio = <&pca6416_1 2 GPIO_ACTIVE_LOW>;
snps,reset-delays-us = <10 20 200000>;
status = "okay";

--
2.39.1

2023-02-13 21:48:10

by Fabio Estevam

Subject: Re: [PATCH 2/2] arm64: dts: imx8dxl-evk: Fix eqos phy reset gpio

On Mon, Feb 13, 2023 at 6:31 PM Andrew Halaney <[email protected]> wrote:
>
> The property is named snps,reset-gpio. Update the name accordingly so
> the corresponding phy is reset.
>
> Fixes: 8dd495d12374 ("arm64: dts: freescale: add support for i.MX8DXL EVK board")
> Signed-off-by: Andrew Halaney <[email protected]>

Reviewed-by: Fabio Estevam <[email protected]>

2023-02-14 08:12:03

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/2] dt-bindings: net: snps,dwmac: Fix snps,reset-delays-us dependency

On 13/02/2023 22:31, Andrew Halaney wrote:
> The schema had snps,reset-delay-us as dependent on snps,reset-gpio. The
> actual property is called snps,reset-delays-us, so fix this to catch any
> devicetree defining snsps,reset-delays-us without snps,reset-gpio.
>
> Fixes: 7db3545aef5f ("dt-bindings: net: stmmac: Convert the binding to a schemas")
> Signed-off-by: Andrew Halaney <[email protected]>
> ---


Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-02-14 08:12:48

by Krzysztof Kozlowski

Subject: Re: [PATCH 2/2] arm64: dts: imx8dxl-evk: Fix eqos phy reset gpio

On 13/02/2023 22:31, Andrew Halaney wrote:
> The property is named snps,reset-gpio. Update the name accordingly so
> the corresponding phy is reset.
>
> Fixes: 8dd495d12374 ("arm64: dts: freescale: add support for i.MX8DXL EVK board")
> Signed-off-by: Andrew Halaney <[email protected]>
> ---
> arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
> index 1bcf228a22b8..b6d7c2526131 100644
> --- a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
> @@ -121,7 +121,7 @@ &eqos {
> phy-handle = <&ethphy0>;
> nvmem-cells = <&fec_mac1>;
> nvmem-cell-names = "mac-address";
> - snps,reset-gpios = <&pca6416_1 2 GPIO_ACTIVE_LOW>;
> + snps,reset-gpio = <&pca6416_1 2 GPIO_ACTIVE_LOW>;

I don't think it's correct change. This property is deprecated. Also
uses old, deprecated suffix gpio.

Best regards,
Krzysztof

2023-02-14 14:17:39

by Andrew Halaney

Subject: Re: [PATCH 2/2] arm64: dts: imx8dxl-evk: Fix eqos phy reset gpio

On Tue, Feb 14, 2023 at 09:12:36AM +0100, Krzysztof Kozlowski wrote:
> On 13/02/2023 22:31, Andrew Halaney wrote:
> > The property is named snps,reset-gpio. Update the name accordingly so
> > the corresponding phy is reset.
> >
> > Fixes: 8dd495d12374 ("arm64: dts: freescale: add support for i.MX8DXL EVK board")
> > Signed-off-by: Andrew Halaney <[email protected]>
> > ---
> > arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
> > index 1bcf228a22b8..b6d7c2526131 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
> > @@ -121,7 +121,7 @@ &eqos {
> > phy-handle = <&ethphy0>;
> > nvmem-cells = <&fec_mac1>;
> > nvmem-cell-names = "mac-address";
> > - snps,reset-gpios = <&pca6416_1 2 GPIO_ACTIVE_LOW>;
> > + snps,reset-gpio = <&pca6416_1 2 GPIO_ACTIVE_LOW>;
>
> I don't think it's correct change. This property is deprecated. Also
> uses old, deprecated suffix gpio.
>

I mentally grandfathered this in, but after your comment realized it
shouldn't be. I'll post a v2 with the reset handled in the phy
node directly. Thanks!