2023-02-14 08:43:30

by Horatiu Vultur

Subject: [PATCH net-next] net: lan966x: Use automatic selection of VCAP rule actionset

Now the VCAP API automatically selects the action set, therefore is
not needed to be hardcoded anymore to hardcode the action in the
lan966x. Therefore remove this.

Signed-off-by: Horatiu Vultur <[email protected]>
---
drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c b/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c
index bd10a71897418..f960727ecaeec 100644
--- a/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c
+++ b/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c
@@ -261,8 +261,6 @@ static int lan966x_tc_flower_add(struct lan966x_port *port,
0);
err |= vcap_rule_add_action_u32(vrule, VCAP_AF_MASK_MODE,
LAN966X_PMM_REPLACE);
- err |= vcap_set_rule_set_actionset(vrule,
- VCAP_AFS_BASE_TYPE);
if (err)
goto out;

--
2.38.0

2023-02-16 05:31:18

by Jakub Kicinski

Subject: Re: [PATCH net-next] net: lan966x: Use automatic selection of VCAP rule actionset

On Tue, 14 Feb 2023 09:42:06 +0100 Horatiu Vultur wrote:
> Now the VCAP API automatically selects the action set, therefore is
> not needed to be hardcoded anymore to hardcode the action in the
> lan966x. Therefore remove this.

The commit message needs some attention here.
While at it - instead of saying "now" could you provide the commit
reference? E.g. "Since commit $hash ("$title") the VCAP API...".

2023-02-16 10:38:02

by Horatiu Vultur

Subject: Re: [PATCH net-next] net: lan966x: Use automatic selection of VCAP rule actionset

The 02/15/2023 21:30, Jakub Kicinski wrote:

Hi Jakub,

>
> On Tue, 14 Feb 2023 09:42:06 +0100 Horatiu Vultur wrote:
> > Now the VCAP API automatically selects the action set, therefore is
> > not needed to be hardcoded anymore to hardcode the action in the
> > lan966x. Therefore remove this.
>
> The commit message needs some attention here.
> While at it - instead of saying "now" could you provide the commit
> reference? E.g. "Since commit $hash ("$title") the VCAP API...".

I will update this in the next version. Thanks for the feedback!

--
/Horatiu