2023-02-15 09:47:21

by Lucas Tanure

[permalink] [raw]
Subject: [PATCH] ASoC: soc-dapm.h: fixup warning struct snd_pcm_substream not declared

Add sound/pcm.h header to include struct snd_pcm_substream used in
snd_soc_dapm_update_dai function.

Fixes: 078a85f2806f ("ASoC: dapm: Only power up active channels from a DAI")
Signed-off-by: Lucas Tanure <[email protected]>
---
include/sound/soc-dapm.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/include/sound/soc-dapm.h b/include/sound/soc-dapm.h
index 77495e5988c1..8fbb50a11d80 100644
--- a/include/sound/soc-dapm.h
+++ b/include/sound/soc-dapm.h
@@ -14,6 +14,7 @@
#include <sound/control.h>
#include <sound/soc-topology.h>
#include <sound/asoc.h>
+#include <sound/pcm.h>

struct device;
struct snd_soc_pcm_runtime;
--
2.39.1



Subject: Re: [PATCH] ASoC: soc-dapm.h: fixup warning struct snd_pcm_substream not declared

Il 15/02/23 10:46, Lucas Tanure ha scritto:
> Add sound/pcm.h header to include struct snd_pcm_substream used in
> snd_soc_dapm_update_dai function.
>
> Fixes: 078a85f2806f ("ASoC: dapm: Only power up active channels from a DAI")
> Signed-off-by: Lucas Tanure <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>



2023-02-15 12:55:26

by Charles Keepax

[permalink] [raw]
Subject: Re: [PATCH] ASoC: soc-dapm.h: fixup warning struct snd_pcm_substream not declared

On Wed, Feb 15, 2023 at 09:46:43AM +0000, Lucas Tanure wrote:
> Add sound/pcm.h header to include struct snd_pcm_substream used in
> snd_soc_dapm_update_dai function.
>
> Fixes: 078a85f2806f ("ASoC: dapm: Only power up active channels from a DAI")
> Signed-off-by: Lucas Tanure <[email protected]>
> ---

Reviewed-by: Charles Keepax <[email protected]>

Thanks,
Charles

2023-02-15 12:59:15

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] ASoC: soc-dapm.h: fixup warning struct snd_pcm_substream not declared

On Wed, Feb 15, 2023 at 09:46:43AM +0000, Lucas Tanure wrote:
> Add sound/pcm.h header to include struct snd_pcm_substream used in
> snd_soc_dapm_update_dai function.

> +#include <sound/pcm.h>
>
> struct device;
> struct snd_soc_pcm_runtime;

This should be a forward declaration of the struct like the
adjacent forward declarations that are already there, we only
pass a pointer to it we don't need the contents.


Attachments:
(No filename) (419.00 B)
signature.asc (488.00 B)
Download all attachments