2023-02-17 03:13:32

by Thomas Weißschuh

Subject: [PATCH] dma-buf: make kobj_type structure constant

Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
the driver core allows the usage of const struct kobj_type.

Take advantage of this to constify the structure definition to prevent
modification at runtime.

Signed-off-by: Thomas Weißschuh <[email protected]>
---
drivers/dma-buf/dma-buf-sysfs-stats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma-buf/dma-buf-sysfs-stats.c b/drivers/dma-buf/dma-buf-sysfs-stats.c
index fbf725fae7c1..6cfbbf0720bd 100644
--- a/drivers/dma-buf/dma-buf-sysfs-stats.c
+++ b/drivers/dma-buf/dma-buf-sysfs-stats.c
@@ -112,7 +112,7 @@ static void dma_buf_sysfs_release(struct kobject *kobj)
kfree(sysfs_entry);
}

-static struct kobj_type dma_buf_ktype = {
+static const struct kobj_type dma_buf_ktype = {
.sysfs_ops = &dma_buf_stats_sysfs_ops,
.release = dma_buf_sysfs_release,
.default_groups = dma_buf_stats_default_groups,

---
base-commit: 3ac88fa4605ec98e545fb3ad0154f575fda2de5f
change-id: 20230217-kobj_type-dma-buf-a2ea6a8a1de3

Best regards,
--
Thomas Weißschuh <[email protected]>

2023-02-17 09:47:32

by Christian König

Subject: Re: [PATCH] dma-buf: make kobj_type structure constant

Am 17.02.23 um 04:13 schrieb Thomas Weißschuh:
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
>
> Take advantage of this to constify the structure definition to prevent
> modification at runtime.
>
> Signed-off-by: Thomas Weißschuh <[email protected]>

Reviewed-by: Christian König <[email protected]>

I will pick this up for upstreaming through drm-misc-next.

Thanks,
Christian.

> ---
> drivers/dma-buf/dma-buf-sysfs-stats.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma-buf/dma-buf-sysfs-stats.c b/drivers/dma-buf/dma-buf-sysfs-stats.c
> index fbf725fae7c1..6cfbbf0720bd 100644
> --- a/drivers/dma-buf/dma-buf-sysfs-stats.c
> +++ b/drivers/dma-buf/dma-buf-sysfs-stats.c
> @@ -112,7 +112,7 @@ static void dma_buf_sysfs_release(struct kobject *kobj)
> kfree(sysfs_entry);
> }
>
> -static struct kobj_type dma_buf_ktype = {
> +static const struct kobj_type dma_buf_ktype = {
> .sysfs_ops = &dma_buf_stats_sysfs_ops,
> .release = dma_buf_sysfs_release,
> .default_groups = dma_buf_stats_default_groups,
>
> ---
> base-commit: 3ac88fa4605ec98e545fb3ad0154f575fda2de5f
> change-id: 20230217-kobj_type-dma-buf-a2ea6a8a1de3
>
> Best regards,