2023-02-27 03:09:52

by Thomas Weißschuh

Subject: [PATCH] efi: x86: make kobj_type structure constant

Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
the driver core allows the usage of const struct kobj_type.

Take advantage of this to constify the structure definition to prevent
modification at runtime.

Signed-off-by: Thomas Weißschuh <[email protected]>
---
arch/x86/platform/efi/runtime-map.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/platform/efi/runtime-map.c b/arch/x86/platform/efi/runtime-map.c
index bbee682ef8cd..a6f02cef3ca2 100644
--- a/arch/x86/platform/efi/runtime-map.c
+++ b/arch/x86/platform/efi/runtime-map.c
@@ -93,7 +93,7 @@ static void map_release(struct kobject *kobj)
kfree(entry);
}

-static struct kobj_type __refdata map_ktype = {
+static const struct kobj_type __refconst map_ktype = {
.sysfs_ops = &map_attr_ops,
.default_groups = def_groups,
.release = map_release,

---
base-commit: 2fcd07b7ccd5fd10b2120d298363e4e6c53ccf9c
change-id: 20230227-kobj_type-x86-efi-7591b1343b08

Best regards,
--
Thomas Weißschuh <[email protected]>

2023-02-27 16:35:00

by Ard Biesheuvel

Subject: Re: [PATCH] efi: x86: make kobj_type structure constant

On Mon, 27 Feb 2023 at 04:09, Thomas Weißschuh <[email protected]> wrote:
>
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
>
> Take advantage of this to constify the structure definition to prevent
> modification at runtime.
>
> Signed-off-by: Thomas Weißschuh <[email protected]>

Thanks, I'll queue these up after the merge window.

> ---
> arch/x86/platform/efi/runtime-map.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/platform/efi/runtime-map.c b/arch/x86/platform/efi/runtime-map.c
> index bbee682ef8cd..a6f02cef3ca2 100644
> --- a/arch/x86/platform/efi/runtime-map.c
> +++ b/arch/x86/platform/efi/runtime-map.c
> @@ -93,7 +93,7 @@ static void map_release(struct kobject *kobj)
> kfree(entry);
> }
>
> -static struct kobj_type __refdata map_ktype = {
> +static const struct kobj_type __refconst map_ktype = {
> .sysfs_ops = &map_attr_ops,
> .default_groups = def_groups,
> .release = map_release,
>
> ---
> base-commit: 2fcd07b7ccd5fd10b2120d298363e4e6c53ccf9c
> change-id: 20230227-kobj_type-x86-efi-7591b1343b08
>
> Best regards,
> --
> Thomas Weißschuh <[email protected]>
>